Attachment 373589 Details for Bug 199130 – Patch

[patch] Patch

patch.txt (text/plain), 2.29 KB, created by Nikita Vasilyev on 2019-07-06 18:27:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-07-06 18:27:14 PDT

Size: 2.29 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index c4f19a78df7..b32ee5b34ea 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-07-06  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
>+        https://bugs.webkit.org/show_bug.cgi?id=199090
>+        <rdar://problem/51965431>
>+
>+        Reviewed by Devin Rousso.
>+
>+        `}` gets added by WI.tokenizeCSSValue (called by SpreadsheetStyleProperty.prototype._renderValue)
>+        when it encounters unbalanced quotes. Fix unbalanced quotes by re-rendering the value from the model,
>+        not the DOM content.
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
>+        For consistency, render property name from the model as well.
>+
> 2019-07-02  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Elements: allow nodes to be copied and pasted
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index dd7a0c5f4e2..830adfb9366 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -359,16 +359,14 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
> 
>     spreadsheetTextFieldDidCommit(textField, {direction})
>     {
>-        let propertyName = this._nameTextField.value.trim();
>-        let propertyValue = this._valueTextField.value.trim();
>         let willRemoveProperty = false;
>         let isEditingName = textField === this._nameTextField;
> 
>-        if (!propertyName || (!propertyValue && !isEditingName && direction === "forward"))
>+        if (!this._property.name || (!this._property.rawValue && !isEditingName && direction === "forward"))
>             willRemoveProperty = true;
> 
>         if (!isEditingName && !willRemoveProperty)
>-            this._renderValue(propertyValue);
>+            this._renderValue(this._property.rawValue);
> 
>         if (direction === "forward") {
>             if (isEditingName && !willRemoveProperty) {

Actions: View | Formatted Diff | Diff

Attachments on bug 199130: 372690 | 373589