Attachment 373584 Details for Bug 198852 – Patch

[patch] Patch

bug-198852-20190706150954.patch (text/plain), 1.72 KB, created by Daniel Bates on 2019-07-06 15:09:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-07-06 15:09:54 PDT

Size: 1.72 KB

patch

obsolete

>Subversion Revision: 247155
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 017fa24ca95882fa220a4eaefca84fb7965071b4..66c3ab9cfff84b9488ef5c3dc4f41acd9886c616 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-07-06  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Selection handles "Lollipops" can become gray and stay gray
>+        https://bugs.webkit.org/show_bug.cgi?id=198852
>+        <rdar://problem/51736130>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Tell the text interaction assistant to update the selection UI when the tint color changes.
>+        We do this by way of deactivating and activating selection.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView tintColorDidChange]):
>+
> 2019-07-02  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Support select all in non-editable element
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 43eac265b903e92a5e8a64f80ab7296f92fa3116..7954a0951b8dc905ba7c2754dd06adcea138fa9d 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -2887,7 +2887,13 @@ - (void)_updateInteractionTintColor
> - (void)tintColorDidChange
> {
>     [super tintColorDidChange];
>+
>+    BOOL shouldUpdateTextSelection = self.isFirstResponder && [self canShowNonEmptySelectionView];
>+    if (shouldUpdateTextSelection)
>+        [_textSelectionAssistant deactivateSelection];
>     [self _updateInteractionTintColor];
>+    if (shouldUpdateTextSelection)
>+        [_textSelectionAssistant activateSelection];
> }
> 
> - (BOOL)canPerformAction:(SEL)action withSender:(id)sender

Actions: View | Formatted Diff | Diff

Attachments on bug 198852: 372108 | 373584