Attachment 373580 Details for Bug 199549 – Patch

[patch] Patch

bug-199549-20190706131831.patch (text/plain), 2.55 KB, created by Devin Rousso on 2019-07-06 13:18:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-07-06 13:18:32 PDT

Size: 2.55 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 81b5be3e689e68d8dd6e2fd96a6bdecc06460d12..d272d44d1f2d71bf2dba722b4d9de85f74283630 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-07-06  Devin Rousso  <drousso@apple.com>
>+
>+        Enabling the Layers tab hides the paint flashing button
>+        https://bugs.webkit.org/show_bug.cgi?id=199549
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Still show the Compositing Borders and Paint Flashing navigation items in the Elements tab
>+        even when the Layers tab is enabled (just like the Layers details sidebar).
>+
>+        * UserInterface/Views/DOMTreeContentView.js:
>+        (WI.DOMTreeContentView.prototype.get navigationItems):
>+        (WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
>+
> 2019-07-05  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: current call frame indicator not visible in dark mode
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js b/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
>index 5db19b81fcab70137b4fa6559daddb002695f58c..850c934d2ce64751331f41e96171894c64fe4e19 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
>@@ -128,13 +128,11 @@ WI.DOMTreeContentView = class DOMTreeContentView extends WI.ContentView
>         if (this._showRulersButtonNavigationItem)
>            items.unshift(this._showRulersButtonNavigationItem);
> 
>-        if (!WI.settings.experimentalEnableLayersTab.value) {
>-            if (this._compositingBordersButtonNavigationItem)
>-                items.push(this._compositingBordersButtonNavigationItem);
>+        if (this._compositingBordersButtonNavigationItem)
>+            items.push(this._compositingBordersButtonNavigationItem);
> 
>-            if (this._paintFlashingButtonNavigationItem)
>-                items.push(this._paintFlashingButtonNavigationItem);
>-       }
>+        if (this._paintFlashingButtonNavigationItem)
>+            items.push(this._paintFlashingButtonNavigationItem);
> 
>         return items;
>     }
>@@ -606,9 +604,6 @@ WI.DOMTreeContentView = class DOMTreeContentView extends WI.ContentView
> 
>     _updateCompositingBordersButtonToMatchPageSettings()
>     {
>-        if (WI.settings.experimentalEnableLayersTab.value)
>-            return;
>-
>         var button = this._compositingBordersButtonNavigationItem;
> 
>         // We need to sync with the page settings since these can be controlled

Actions: View | Formatted Diff | Diff

Attachments on bug 199549: 373580