Attachment 373577 Details for Bug 199554 – Patch

[patch] Patch

bug-199554-20190706123914.patch (text/plain), 4.49 KB, created by Devin Rousso on 2019-07-06 12:39:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-07-06 12:39:14 PDT

Size: 4.49 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 81b5be3e689e68d8dd6e2fd96a6bdecc06460d12..da688e2774d22cd07e6502742765487231165c16 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-07-06  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Debugger: special breakpoints and event targets should be sorted into separate "areas"
>+        https://bugs.webkit.org/show_bug.cgi?id=199554
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Move the special All Requests breakpoint down to be right above all other URL breakpoints.
>+        Move the `window` object tree element below other DOM node tree elements.
>+
>+        * UserInterface/Views/DebuggerSidebarPanel.js:
>+        (WI.DebuggerSidebarPanel.prototype._addTreeElement):
>+        * UserInterface/Views/SourcesNavigationSidebarPanel.js:
>+        (WI.SourcesNavigationSidebarPanel.prototype._insertDebuggerTreeElement):
>+
> 2019-07-05  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: current call frame indicator not visible in dark mode
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>index 9bb6a68485e8fbcddd5e560742e5d761075d0ede..95ab09f313c9420ea613a700ab4b923a69d91427 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>@@ -1065,11 +1065,12 @@ WI.DebuggerSidebarPanel = class DebuggerSidebarPanel extends WI.NavigationSideba
>                 (treeElement) => treeElement.representedObject === WI.debuggerManager.allExceptionsBreakpoint,
>                 (treeElement) => treeElement.representedObject === WI.debuggerManager.uncaughtExceptionsBreakpoint,
>                 (treeElement) => treeElement.representedObject === WI.debuggerManager.assertionFailuresBreakpoint,
>-                (treeElement) => treeElement.representedObject === WI.domDebuggerManager.allRequestsBreakpoint,
>                 (treeElement) => treeElement instanceof WI.BreakpointTreeElement || treeElement instanceof WI.ResourceTreeElement || treeElement instanceof WI.ScriptTreeElement,
>                 (treeElement) => treeElement instanceof WI.EventBreakpointTreeElement,
>                 (treeElement) => treeElement instanceof WI.DOMNodeTreeElement,
>+                (treeElement) => treeElement.representedObject === DebuggerSidebarPanel.__windowEventTargetRepresentedObject,
>                 (treeElement) => treeElement instanceof WI.DOMBreakpointTreeElement,
>+                (treeElement) => treeElement.representedObject === WI.domDebuggerManager.allRequestsBreakpoint,
>                 (treeElement) => treeElement instanceof WI.URLBreakpointTreeElement,
>             ];
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
>index 1bd1dc6bc6e8295b3092ff28b245307d6a7299be..841011d8f82c6246ea99e91054a8aaf2e6c3bfbe 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
>@@ -853,11 +853,12 @@ WI.SourcesNavigationSidebarPanel = class SourcesNavigationSidebarPanel extends W
>                 (treeElement) => treeElement.representedObject === WI.debuggerManager.allExceptionsBreakpoint,
>                 (treeElement) => treeElement.representedObject === WI.debuggerManager.uncaughtExceptionsBreakpoint,
>                 (treeElement) => treeElement.representedObject === WI.debuggerManager.assertionFailuresBreakpoint,
>-                (treeElement) => treeElement.representedObject === WI.domDebuggerManager.allRequestsBreakpoint,
>                 (treeElement) => treeElement instanceof WI.BreakpointTreeElement || treeElement instanceof WI.ResourceTreeElement || treeElement instanceof WI.ScriptTreeElement,
>                 (treeElement) => treeElement instanceof WI.EventBreakpointTreeElement,
>                 (treeElement) => treeElement instanceof WI.DOMNodeTreeElement,
>+                (treeElement) => treeElement.representedObject === SourcesNavigationSidebarPanel.__windowEventTargetRepresentedObject,
>                 (treeElement) => treeElement instanceof WI.DOMBreakpointTreeElement,
>+                (treeElement) => treeElement.representedObject === WI.domDebuggerManager.allRequestsBreakpoint,
>                 (treeElement) => treeElement instanceof WI.URLBreakpointTreeElement,
>             ];
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199554: 373577 | 373578