WebKit Bugzilla
Attachment 373542 Details for
Bug 199535
: WebBackForwardListItem::setPageState should receive pageState by reference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199535-20190705170537.patch (text/plain), 2.07 KB, created by
Michael Catanzaro
on 2019-07-05 15:05:38 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Michael Catanzaro
Created:
2019-07-05 15:05:38 PDT
Size:
2.07 KB
patch
obsolete
>Subversion Revision: 247168 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index ac2ecedfd155c32c15894f379b4e4e15b2daa00b..9b90f53edd72ecbcc5685817bc1fbabc6643a3cb 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,19 @@ >+2019-07-05 Michael Catanzaro <mcatanzaro@igalia.com> >+ >+ WebBackForwardListItem::setPageState should receive pageState by reference >+ https://bugs.webkit.org/show_bug.cgi?id=199535 >+ >+ Reviewed by NOBODY (OOPS!) >+ >+ Coverity is complaining here about copying PageState by value in the parameter list. It's >+ sort of a false positive, in that the PageState really does need to be copied here, so this >+ is the best we can do. But pass by value and then WTFMove() is a pretty strange way to write >+ it. Just passing by reference would be better. Then it will be copied into >+ m_itemState.pageState.. >+ >+ * Shared/WebBackForwardListItem.h: >+ (WebKit::WebBackForwardListItem::setPageState): >+ > 2019-07-05 Zalan Bujtas <zalan@apple.com> > > [ContentChangeObserver] REGRESSION (r247015): facebook photo/video upload button is unresponsive to user interaction. >diff --git a/Source/WebKit/Shared/WebBackForwardListItem.h b/Source/WebKit/Shared/WebBackForwardListItem.h >index 3b9b0bfd9b1e48b756329c55c6a442da9de19969..5369c71cd2aec3ef58655437ad7972e4f2878091 100644 >--- a/Source/WebKit/Shared/WebBackForwardListItem.h >+++ b/Source/WebKit/Shared/WebBackForwardListItem.h >@@ -60,7 +60,7 @@ public: > WebCore::ProcessIdentifier lastProcessIdentifier() const { return m_lastProcessIdentifier; } > void setLastProcessIdentifier(const WebCore::ProcessIdentifier& identifier) { m_lastProcessIdentifier = identifier; } > >- void setPageState(PageState pageState) { m_itemState.pageState = WTFMove(pageState); } >+ void setPageState(const PageState& pageState) { m_itemState.pageState = pageState; } > const PageState& pageState() const { return m_itemState.pageState; } > > const String& originalURL() const { return m_itemState.pageState.mainFrameState.originalURLString; }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199535
:
373542
|
373971