Attachment 373541 Details for Bug 199532 – Patch

[patch] Patch

bug-199532-20190705165558.patch (text/plain), 1.47 KB, created by Michael Catanzaro on 2019-07-05 14:55:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-07-05 14:55:59 PDT

Size: 1.47 KB

patch

obsolete

>Subversion Revision: 247168
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ac2ecedfd155c32c15894f379b4e4e15b2daa00b..90a8ae2c5757e20e868b415b1281225c4fd2dfbc 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-07-05  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [GTK] ViewGestureController constructor leaves m_direction uninitialized
>+        https://bugs.webkit.org/show_bug.cgi?id=199532
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is harmless because it should never be read until after it's initialized, but still not
>+        robust. Fix it by assuming Back as the default value until the first swipe begins.
>+
>+        * UIProcess/ViewGestureController.h:
>+
> 2019-07-05  Zalan Bujtas  <zalan@apple.com>
> 
>         [ContentChangeObserver] REGRESSION (r247015): facebook photo/video upload button is unresponsive to user interaction.
>diff --git a/Source/WebKit/UIProcess/ViewGestureController.h b/Source/WebKit/UIProcess/ViewGestureController.h
>index 7b020ef5f0631f08a87115005cb8afcb88cad2a4..7cd6e8fe09124b9b4ed8df06023f56733226ec53 100644
>--- a/Source/WebKit/UIProcess/ViewGestureController.h
>+++ b/Source/WebKit/UIProcess/ViewGestureController.h
>@@ -388,7 +388,7 @@ private:
> 
>         State m_state { State::None };
> 
>-        SwipeDirection m_direction;
>+        SwipeDirection m_direction { SwipeDirection::Back };
>         RefPtr<WebBackForwardListItem> m_targetItem;
>         unsigned m_tickCallbackID { 0 };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199532: 373541