Attachment 373533 Details for Bug 199530 – Patch

[patch] Patch

bug-199530-20190705140219.patch (text/plain), 2.31 KB, created by Jer Noble on 2019-07-05 14:02:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-07-05 14:02:19 PDT

Size: 2.31 KB

patch

obsolete

>Subversion Revision: 247109
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 21222a72b9b108cd4c155376ae7b9d530513f7ea..2ca207a95df2c08468438b3d90fe7aedd450f25b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-07-05  Jer Noble  <jer.noble@apple.com>
>+
>+        Revert change to block playback when process is ostensibly "suspended".
>+        https://bugs.webkit.org/show_bug.cgi?id=199530
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In r243958, a drive-by-fix was added that blocked playback when the WebProcess thought it
>+        was susposed to be suspended. The intent was to keep the AVAudioSession for the process
>+        from being activated just before the process was suspended, and thus avoid receiving an
>+        "interruption" and having the AVAudioSession deactivated out from under us upon resuming.
>+
>+        Unfortunately, this caused problems when another process resumes the WebContent process
>+        in order to start playback; namely the Now Playing UI's play button. Because we may receive
>+        the play command long before whe notice that we've been resumed, the WebContent process
>+        may refuse to honor the play command because it thinks its supposed to be suspended.
>+
>+        * platform/audio/PlatformMediaSessionManager.cpp:
>+        (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
>+
> 2019-07-03  Jer Noble  <jer.noble@apple.com>
> 
>         HTMLMediaElement can hold onto display sleep assertion while process is suspended.
>diff --git a/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp b/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
>index 6f9969536e54da37077671090ea4d3aeb3fa636e..bb1cd9186bcecdff579b4ad3599fa4be94ed9acd 100644
>--- a/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
>+++ b/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
>@@ -209,11 +209,6 @@ bool PlatformMediaSessionManager::sessionWillBeginPlayback(PlatformMediaSession&
>         return false;
>     }
> 
>-    if (m_processIsSuspended) {
>-        ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " returning false because process is suspended");
>-        return false;
>-    }
>-
> #if USE(AUDIO_SESSION)
>     if (activeAudioSessionRequired()) {
>         if (!AudioSession::sharedSession().tryToSetActive(true)) {

Actions: View | Formatted Diff | Diff

Attachments on bug 199530: 373533