Attachment 373532 Details for Bug 199047 – Patch

[patch] Patch

bug-199047-20190705135924.patch (text/plain), 1.94 KB, created by Devin Rousso on 2019-07-05 13:59:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-07-05 13:59:25 PDT

Size: 1.94 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index c4f19a78df7c68922f7e01d7b0810c1a46fb3759..44ef2ea3494dc7d5387e5f2002557d045d232091 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-07-05  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: current call frame indicator not visible in dark mode
>+        https://bugs.webkit.org/show_bug.cgi?id=199047
>+        <rdar://problem/51922895>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/CallFrameTreeElement.css:
>+        (.tree-outline .item.call-frame .status > .status-image):
>+        (.tree-outline .item.call-frame.selected .status > .status-image):
>+        Replace the CSS variables used for `fill` with their actual color value (in `light` mode),
>+        as the semantic "name" of the variable doesn't really match its usage. As an example, the
>+        current call frame shouldn't rely on the value of `--border-color`, as it's not a "border".
>+
> 2019-07-02  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Elements: allow nodes to be copied and pasted
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css b/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css
>index 30940a624e82fa234eeb0de5b8b6c4a4d0f4ca31..2ab3ecd53955e9969b8adfb943dfe1990427b922 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css
>@@ -52,11 +52,11 @@ body[dir=rtl] .tree-outline .item.call-frame .status {
> .tree-outline .item.call-frame .status > .status-image {
>     width: 17px;
>     height: 17px;
>-    fill: var(--border-color);
>+    fill: hsl(0, 0%, 70%);
> }
> 
> .tree-outline .item.call-frame.selected .status > .status-image {
>-    fill: var(--border-color-dark);
>+    fill: hsl(0, 0%, 57%);
> }
> 
> .tree-outline:focus .item.call-frame.selected .status > .status-image {

Actions: View | Formatted Diff | Diff

Attachments on bug 199047: 372507 | 372508 | 372567 | 373532 | 373535