Attachment 373497 Details for Bug 199516 – WIP Patch

[patch] WIP Patch

199516_wip.patch (text/plain), 1.08 KB, created by Chris Dumez on 2019-07-05 08:37:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-07-05 08:37:14 PDT

Size: 1.08 KB

patch

obsolete

>diff --git a/Source/WTF/wtf/CompletionHandler.h b/Source/WTF/wtf/CompletionHandler.h
>index fda54a6aad0..b0506c204d0 100644
>--- a/Source/WTF/wtf/CompletionHandler.h
>+++ b/Source/WTF/wtf/CompletionHandler.h
>@@ -26,6 +26,7 @@
> #pragma once
> 
> #include <wtf/Function.h>
>+#include <wtf/MainThread.h>
> 
> namespace WTF {
> 
>@@ -40,6 +41,7 @@ public:
>     template<typename CallableType, class = typename std::enable_if<std::is_rvalue_reference<CallableType&&>::value>::type>
>     CompletionHandler(CallableType&& callable)
>         : m_function(WTFMove(callable))
>+        , m_wasConstructedOnMainThread(isMainThread())
>     {
>     }
> 
>@@ -55,12 +57,14 @@ public:
> 
>     Out operator()(In... in)
>     {
>+        RELEASE_ASSERT(m_wasConstructedOnMainThread == isMainThread()); // FIXME: Make it a debug ASSERT().
>         ASSERT_WITH_MESSAGE(m_function, "Completion handler should not be called more than once");
>         return std::exchange(m_function, nullptr)(std::forward<In>(in)...);
>     }
> 
> private:
>     Function<Out(In...)> m_function;
>+    bool m_wasConstructedOnMainThread;
> };
> 
> namespace Detail {

Flags:

ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 199516: 373493 | 373497 | 373506 | 373509 | 373513 | 373514 | 373528 | 373530 | 373536 | 373549 | 373641