Attachment 373485 Details for Bug 199510 – Patch

[patch] Patch

bug-199510-20190705120509.patch (text/plain), 2.17 KB, created by Adrian Perez on 2019-07-05 02:05:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2019-07-05 02:05:10 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 247147
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 79d3da14df26253992a5f7ba6b144f10b225b2c5..480b3facb787a8da77ac5b8de9bf076cef930e7a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-07-05  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [ATK] Do not use C linkage for functions using C++ features
>+        https://bugs.webkit.org/show_bug.cgi?id=199510
>+        <rdar://problem/52674702>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests needed.
>+
>+        * accessibility/atk/WebKitAccessible.h: Move function and type declarations involving
>+        C++ features outside of the block delimited by the G_BEGIN_DECLS and G_END_DECLS macros,
>+        which were setting the C linkage.
>+
> 2019-07-04  Zalan Bujtas  <zalan@apple.com>
> 
>         [ContentChangeObserver] didFinishTransition triggers a nested style recalc via isConsideredClickable
>diff --git a/Source/WebCore/accessibility/atk/WebKitAccessible.h b/Source/WebCore/accessibility/atk/WebKitAccessible.h
>index 7d5637a158328247bd608bd969de0343969d02f1..16e446245f920898130b40ed5c45da7b082a7ae9 100644
>--- a/Source/WebCore/accessibility/atk/WebKitAccessible.h
>+++ b/Source/WebCore/accessibility/atk/WebKitAccessible.h
>@@ -55,6 +55,14 @@ struct _WebKitAccessibleClass {
>     AtkObjectClass parentClass;
> };
> 
>+GType webkit_accessible_get_type(void);
>+
>+G_END_DECLS
>+
>+// The definitions below are only used in C++ code, and some use C++ types,
>+// therefore they should be outside of the G_BEGIN_DECLS/G_END_DECLS block
>+// to make them use the C++ ABI.
>+
> enum AtkCachedProperty {
>     AtkCachedAccessibleName,
>     AtkCachedAccessibleDescription,
>@@ -67,8 +75,6 @@ enum AtkCachedProperty {
>     AtkCachedImageDescription
> };
> 
>-GType webkit_accessible_get_type(void);
>-
> WebKitAccessible* webkitAccessibleNew(WebCore::AccessibilityObject*);
> 
> WebCore::AccessibilityObject& webkitAccessibleGetAccessibilityObject(WebKitAccessible*);
>@@ -79,6 +85,4 @@ bool webkitAccessibleIsDetached(WebKitAccessible*);
> 
> const char* webkitAccessibleCacheAndReturnAtkProperty(WebKitAccessible*, AtkCachedProperty, CString&&);
> 
>-G_END_DECLS
>-
> #endif // HAVE(ACCESSIBILITY)

Actions: View | Formatted Diff | Diff

Attachments on bug 199510: 373485