Attachment 373483 Details for Bug 199498 – Patch for landing

[patch] Patch for landing

bug-199498-20190705101021.patch (text/plain), 1.37 KB, created by Tadeu Zagallo on 2019-07-05 01:10:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-07-05 01:10:22 PDT

Size: 1.37 KB

patch

obsolete

>Subversion Revision: 247141
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 25959afc019f46914f62a126abbc7c32f3167d22..d5024eff709318ea240a3333c2fb170a1dd609ce 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-04  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        Scribble Heap::m_worldState on destructor
>+        https://bugs.webkit.org/show_bug.cgi?id=199498
>+
>+        Reviewed by Sam Weinig.
>+
>+        The worldState is dumped when we crash due to a failed checkConn, and
>+        this will make it clear if the heap has already been destroyed.
>+
>+        * heap/Heap.cpp:
>+        (JSC::Heap::~Heap):
>+
> 2019-07-03  Sam Weinig  <weinig@apple.com>
> 
>         Adopt simple structured bindings in more places
>diff --git a/Source/JavaScriptCore/heap/Heap.cpp b/Source/JavaScriptCore/heap/Heap.cpp
>index b7e4301a4a995d5c56d8b26bcd53b0f8e436b664..dbd9cbf80a03bc45d09f677007f7188da4fbb53a 100644
>--- a/Source/JavaScriptCore/heap/Heap.cpp
>+++ b/Source/JavaScriptCore/heap/Heap.cpp
>@@ -339,6 +339,9 @@ Heap::Heap(VM* vm, HeapType heapType)
> 
> Heap::~Heap()
> {
>+    // Scribble m_worldState to make it clear that the heap has already been destroyed if we crash in checkConn
>+    m_worldState.store(0xbadbeef0u);
>+
>     forEachSlotVisitor(
>         [&] (SlotVisitor& visitor) {
>             visitor.clearMarkStacks();

Actions: View | Formatted Diff | Diff

Attachments on bug 199498: 373465 | 373483