Attachment 373482 Details for Bug 199505 – Patch

[patch] Patch

bug-199505-20190705083553.patch (text/plain), 3.75 KB, created by Charlie Turner on 2019-07-05 00:35:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2019-07-05 00:35:54 PDT

Size: 3.75 KB

patch

obsolete

>Subversion Revision: 247135
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index a88e8cc5a7d8a1c1e8a1acf98a634f7cf0298321..bd42740f9146f5e1a706009cf8e966e1496e511f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-07-05  Charlie Turner  <cturner@igalia.com>
>+
>+        [GStreamer] media/video-volume.html broken after switching from cubic to linear scaling
>+        https://bugs.webkit.org/show_bug.cgi?id=199505
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        PulseAudio has a conversion process from volume's in
>+        double-precision to uint32_t volumes. Depending on the environment
>+        can introduce rounding errors. Be more lenient in our comparison
>+        code.
>+
>+        * media/video-volume-expected.txt: Update baseline
>+        * media/video-volume.html: Compare volume values within a
>+        reasonable tolerance.
>+
> 2019-07-03  Justin Fan  <justin_fan@apple.com>
> 
>         [WHLSL] Support float4x4 in test harness
>diff --git a/LayoutTests/media/video-volume-expected.txt b/LayoutTests/media/video-volume-expected.txt
>index b6c4cb1a993c564483ae283a7baa82910dd63107..6840e0da0b963493f6649e395afb59af2c3656d3 100644
>--- a/LayoutTests/media/video-volume-expected.txt
>+++ b/LayoutTests/media/video-volume-expected.txt
>@@ -1,18 +1,18 @@
> 
> Test 'volume' attribute
> 
>-EXPECTED (video.volume == '1') OK
>+EXPECTED (compareWithTolerance(video.volume, 1.0) == 'true') OK
> RUN(video.volume = 0.5)
>-EXPECTED (video.volume == '0.5') OK
>+EXPECTED (compareWithTolerance(video.volume, 0.5) == 'true') OK
> RUN(video.volume = 0)
>-EXPECTED (video.volume == '0') OK
>+EXPECTED (compareWithTolerance(video.volume, 0) == 'true') OK
> TEST(video.volume = 1.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
> TEST(video.volume = -0.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
> RUN(video.load())
> EVENT(canplaythrough)
>-EXPECTED (video.volume == '0') OK
>+EXPECTED (compareWithTolerance(video.volume, 0) == 'true') OK
> RUN(video.volume = 0.5)
>-EXPECTED (video.volume == '0.5') OK
>+EXPECTED (compareWithTolerance(video.volume, 0.5) == 'true') OK
> TEST(video.volume = 1.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
> TEST(video.volume = -0.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
> END OF TEST
>diff --git a/LayoutTests/media/video-volume.html b/LayoutTests/media/video-volume.html
>index 59b0b4cf1276b595bfca780fff350f24ca43848a..783ed94406296670c8848d20deb8c7fd2b1a7d2e 100644
>--- a/LayoutTests/media/video-volume.html
>+++ b/LayoutTests/media/video-volume.html
>@@ -3,19 +3,23 @@
> <script src=media-file.js></script>
> <script src=video-test.js></script>
> <script>
>-    testExpected("video.volume", 1.0);
>+    function compareWithTolerance(a, b) {
>+        tolerance = 0.00001;
>+        return (Math.abs(a - b) < tolerance);
>+    }
>+    testExpected("compareWithTolerance(video.volume, 1.0)", true);
>     run("video.volume = 0.5");
>-    testExpected("video.volume", 0.5);
>+    testExpected("compareWithTolerance(video.volume, 0.5)", true);
>     run("video.volume = 0");
>-    testExpected("video.volume", 0);
>+    testExpected("compareWithTolerance(video.volume, 0)", true);
>     testDOMException("video.volume = 1.5", "DOMException.INDEX_SIZE_ERR");
>     testDOMException("video.volume = -0.5", "DOMException.INDEX_SIZE_ERR");
>     video.src = findMediaFile("video", "content/test");
>     run("video.load()");
>     waitForEvent("canplaythrough", function () {
>-        testExpected("video.volume", 0);
>+        testExpected("compareWithTolerance(video.volume, 0)", true);
>         run("video.volume = 0.5");
>-        testExpected("video.volume", 0.5);
>+        testExpected("compareWithTolerance(video.volume, 0.5)", true);
>         testDOMException("video.volume = 1.5", "DOMException.INDEX_SIZE_ERR");
>         testDOMException("video.volume = -0.5", "DOMException.INDEX_SIZE_ERR");
>         endTest();

Actions: View | Formatted Diff | Diff

Attachments on bug 199505: 373482 | 373593 | 373620