Attachment 373462 Details for Bug 199496 – Patch

[patch] Patch

bug-199496-20190704152741.patch (text/plain), 1.93 KB, created by Carlos Alberto Lopez Perez on 2019-07-04 06:27:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Alberto Lopez Perez

Created: 2019-07-04 06:27:42 PDT

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 247138
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6c6e6897ce7d5a187ecb86802d292507fb65c4b8..9c40e22ba8766e89b065b1f51563a7e405b07528 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
>+
>+        [GTK] Fix browserperfdash script after r239522
>+        https://bugs.webkit.org/show_bug.cgi?id=199496
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
>+        (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
>+
> 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
>diff --git a/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py b/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
>index 9161ac2f083adeebbf274f117be66f6fb94c9349..994312d21d374295243b6abc1f1f079f32373b84 100644
>--- a/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
>+++ b/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
>@@ -165,7 +165,7 @@ class BrowserPerfDashRunner(object):
>                 # Run test and save test info
>                 with tempfile.NamedTemporaryFile() as temp_result_file:
>                     benchmark_runner_class = benchmark_runner_subclasses[self._args.driver]
>-                    runner = benchmark_runner_class(plan, self._args.localCopy, self._args.countOverride, self._args.buildDir, temp_result_file.name, self._args.platform, self._args.browser)
>+                    runner = benchmark_runner_class(plan, self._args.localCopy, self._args.countOverride, self._args.buildDir, temp_result_file.name, self._args.platform, self._args.browser, None)
>                     runner.execute()
>                     _log.info('Finished benchmark plan: {plan_name}'.format(plan_name=plan))
>                     # Fill test info for upload

Actions: View | Formatted Diff | Diff

Attachments on bug 199496: 373462