Attachment 373459 Details for Bug 199493 – Patch

[patch] Patch

bug-199493-20190704140340.patch (text/plain), 1.46 KB, created by Carlos Alberto Lopez Perez on 2019-07-04 05:03:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Alberto Lopez Perez

Created: 2019-07-04 05:03:41 PDT

Size: 1.46 KB

patch

obsolete

>Subversion Revision: 247138
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6c6e6897ce7d5a187ecb86802d292507fb65c4b8..00cd019f4f905003c65e6949e6e695ce4c167acc 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
>+
>+        [webkitpy] test-webkitpy is broken on Linux since r246662
>+        https://bugs.webkit.org/show_bug.cgi?id=199493
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/test/main.py:
>+        (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
>+
> 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
>diff --git a/Tools/Scripts/webkitpy/test/main.py b/Tools/Scripts/webkitpy/test/main.py
>index f3bf2dafe39105be7c4097e6f2503df058a18513..d8ae27fa38b6cd55d4715f19e7134e72df0ed08d 100644
>--- a/Tools/Scripts/webkitpy/test/main.py
>+++ b/Tools/Scripts/webkitpy/test/main.py
>@@ -104,7 +104,10 @@ def main():
> def _supports_building_and_running_lldb_tests():
>     # FIXME: Remove when test-lldb is in its own script
>     # https://bugs.webkit.org/show_bug.cgi?id=187916
>-    return not _host.platform.build_version().startswith('19A')
>+    build_version = _host.platform.build_version()
>+    if build_version is None:
>+        return False
>+    return not build_version.startswith('19A')
> 
> 
> def _print_results_as_json(stream, all_test_names, failures, errors):

Actions: View | Formatted Diff | Diff

Attachments on bug 199493: 373459