Attachment 373452 Details for Bug 199491 – Adds a null check

[patch] Adds a null check

bug-199491-20190703203520.patch (text/plain), 1.37 KB, created by Ryosuke Niwa on 2019-07-03 20:35:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-07-03 20:35:21 PDT

Size: 1.37 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 247133)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-07-03  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Crash in WebDragClient::startDrag because GraphicsContext is nullptr
>+        https://bugs.webkit.org/show_bug.cgi?id=199491
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added a nullptr check.
>+
>+        Unfortunately no new tests since we don't have a reproducible test case.
>+
>+        * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
>+        (WebKit::convertImageToBitmap):
>+
> 2019-07-03  Tim Horton  <timothy_horton@apple.com>
> 
>         Data Detectors are not working for context menus in clients that use the legacy preview API
>Index: Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
>===================================================================
>--- Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm	(revision 247132)
>+++ Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm	(working copy)
>@@ -69,6 +69,8 @@ static RefPtr<ShareableBitmap> convertIm
>         return nullptr;
> 
>     auto graphicsContext = bitmap->createGraphicsContext();
>+    if (!graphicsContext)
>+        return nullptr;
> 
>     RetainPtr<NSGraphicsContext> savedContext = [NSGraphicsContext currentContext];
>

Flags:

wenson_hsieh: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199491: 373452