Attachment 373450 Details for Bug 199490 – Patch

[patch] Patch

bug-199490-20190703195948.patch (text/plain), 1.63 KB, created by Eric Carlson on 2019-07-03 19:59:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2019-07-03 19:59:49 PDT

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 247005
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c939e2a01f7760a205b58a9ffd53f48b6dacaa74..0d54c11b302ba24d6814d422457ac91e2eaf2ff9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-07-03  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Touching media controls sometimes shows software keyboard
>+        https://bugs.webkit.org/show_bug.cgi?id=199490
>+        <rdar://problem/52076270>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::dispatchTouchEvent): Only refocus contentEditable elements.
>+
> 2019-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebSockets: add support for sending blob messages when using web sockets platform APIs
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index 3bcf0d785fff52da17b106ebac8f6fd0dd2a4b72..4c3440dfaf2a09e450628e18a5e0bc50fbf589d6 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -2896,7 +2896,7 @@ void WebPage::dispatchTouchEvent(const WebTouchEvent& touchEvent, bool& handled)
>     if (handled && oldFocusedElement) {
>         auto newFocusedFrame = makeRefPtr(m_page->focusController().focusedFrame());
>         auto newFocusedElement = makeRefPtr(newFocusedFrame ? newFocusedFrame->document()->focusedElement() : nullptr);
>-        if (oldFocusedElement == newFocusedElement)
>+        if (oldFocusedElement == newFocusedElement && newFocusedElement->isContentEditable())
>             elementDidRefocus(*newFocusedElement);
>     }
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 199490: 373450 | 373473