Attachment 373446 Details for Bug 199486 – Patch

[patch] Patch

bug-199486-20190703181116.patch (text/plain), 2.13 KB, created by Tim Horton on 2019-07-03 18:11:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2019-07-03 18:11:16 PDT

Size: 2.13 KB

patch

obsolete

>Subversion Revision: 247100
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c81df1f881583d617bcbe7e56a7e2fd8502cb30c..294f973e0fcde763da70f7bdba5e00613afd0711 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-03  Tim Horton  <timothy_horton@apple.com>
>+
>+        Data Detectors are not working for context menus in clients that use the legacy preview API
>+        https://bugs.webkit.org/show_bug.cgi?id=199486
>+        <rdar://problem/52117322>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView assignLegacyDataForContextMenuInteraction]):
>+        The Data Detectors code in the legacy preview path is guarded by a
>+        #define that did not survive upstreaming. Remove it.
>+
> 2019-07-03  Zalan Bujtas  <zalan@apple.com>
> 
>         [ContentChangeObserver] REGRESSION (r244356): Drop down menus collapse without user input - Ebay.com
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 0fc3e4368868f4af0c8fcb45026b4af9d9458b5c..5f1377d6b6c987c62f05f486a0032043c632557f 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -7662,7 +7662,6 @@ - (void)assignLegacyDataForContextMenuInteraction
>             previewViewController = [uiDelegate _webView:_webView previewViewControllerForURL:url];
>         ALLOW_DEPRECATED_DECLARATIONS_END
> 
>-#if USE(DATA_DETECTORS_FOR_DEFAULT_PREVIEW)
>         // Previously, UIPreviewItemController would detect the case where there was no previewViewController
>         // and create one. We need to replicate this code for the new API.
>         if (!previewViewController) {
>@@ -7681,7 +7680,6 @@ - (void)assignLegacyDataForContextMenuInteraction
>             }
>             return;
>         }
>-#endif
> 
>         auto menuTitle = titleForMenu(true, _showLinkPreviews, url, _positionInformation.title);
>         _contextMenuLegacyMenu = menuFromLegacyPreviewOrDefaultActions(previewViewController, defaultActionsFromAssistant, elementInfo, menuTitle);

Actions: View | Formatted Diff | Diff

Attachments on bug 199486: 373446