WebKit Bugzilla
Attachment 373417 Details for
Bug 199465
: REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199465-20190703150559.patch (text/plain), 2.11 KB, created by
Daniel Bates
on 2019-07-03 15:05:59 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2019-07-03 15:05:59 PDT
Size:
2.11 KB
patch
obsolete
>Subversion Revision: 246884 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 7be01784dfe61deabe90d7b09a49d4558fb2d030..3ca5d0c9428d784415c9ef4a8b73393a8975ca2a 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,16 @@ >+2019-07-03 Daniel Bates <dabates@apple.com> >+ >+ REGRESSION (r246817): fast/events/ios/key-events-comprehensive/key-events-{control, control-shift}.html are failing >+ https://bugs.webkit.org/show_bug.cgi?id=199465 >+ <rdar://problem/52613496> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Don't advertise that WebKit can perform cursor movements when there isn't some kind of selection. >+ >+ * UIProcess/ios/WKContentViewInteraction.mm: >+ (-[WKContentView canPerformAction:withSender:]): >+ > 2019-07-02 Daniel Bates <dabates@apple.com> > > [iOS] Support select all in non-editable element >diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >index 0e7a479c305818deffda5031bfb8d40f7bb2a203..fab679c3583a3f8506030c52a1893d7e2f1e4723 100644 >--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >@@ -2895,7 +2895,7 @@ - (BOOL)canPerformAction:(SEL)action withSender:(id)sender > || action == @selector(_moveToEndOfDocument:withHistory:) || action == @selector(_moveToEndOfLine:withHistory:) || action == @selector(_moveToEndOfParagraph:withHistory:) > || action == @selector(_moveToEndOfWord:withHistory:) || action == @selector(_moveToStartOfDocument:withHistory:) || action == @selector(_moveToStartOfLine:withHistory:) > || action == @selector(_moveToStartOfParagraph:withHistory:) || action == @selector(_moveToStartOfWord:withHistory:) || action == @selector(_moveUp:withHistory:)) >- return YES; >+ return !editorState.selectionIsNone; > > if (action == @selector(_deleteByWord) || action == @selector(_deleteForwardAndNotify:) || action == @selector(_deleteToEndOfParagraph) || action == @selector(_deleteToStartOfLine) > || action == @selector(_transpose))
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199465
: 373417