Attachment 373381 Details for Bug 199434 – Patch

[patch] Patch

bug-199434-20190703001939.patch (text/plain), 4.25 KB, created by Andres Gonzalez on 2019-07-02 21:19:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andres Gonzalez

Created: 2019-07-02 21:19:40 PDT

Size: 4.25 KB

patch

obsolete

>Subversion Revision: 247082
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0c9c2c0af53dccacb0b76a64f57ee861f743363e..41741805d48ac5234e9bc6eae6cd7655cf974172 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
>+
>+        Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
>+        https://bugs.webkit.org/show_bug.cgi?id=199434
>+        <rdar://problem/52475140>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Tests were disabled until underlying bug is fixed.
>+
>+        Rolling out a workaround for CharacterIterator::advance bug because it
>+        seems to be causing a hang in Safari.
>+        * editing/Editing.cpp:
>+        (WebCore::visiblePositionForIndexUsingCharacterIterator):
>+
> 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Enhance support of aria-haspopup per ARIA 1.1 specification.
>diff --git a/Source/WebCore/editing/Editing.cpp b/Source/WebCore/editing/Editing.cpp
>index 83f541bdf8300806c8416a8480f0f6781fb6dfc5..fbe586020b16cd4f534904fb0a9f5e45d101ad80 100644
>--- a/Source/WebCore/editing/Editing.cpp
>+++ b/Source/WebCore/editing/Editing.cpp
>@@ -1122,16 +1122,6 @@ VisiblePosition visiblePositionForIndexUsingCharacterIterator(Node& node, int in
>     CharacterIterator it(range.get());
>     it.advance(index - 1);
> 
>-    if (!it.atEnd() && it.text()[0] == '\n') {
>-        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
>-        auto range = it.range();
>-        if (range->startPosition() == range->endPosition()) {
>-            it.advance(1);
>-            if (!it.atEnd())
>-                return VisiblePosition(it.range()->startPosition());
>-        }
>-    }
>-
>     return { it.atEnd() ? range->endPosition() : it.range()->endPosition(), UPSTREAM };
> }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 367a7ccacb06244668d1712710320f7a19a357a0..9003a660d3ae3ccbe9bb77141bfea74298862d5a 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
>+
>+        Safari hanging while loading pages - WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
>+        https://bugs.webkit.org/show_bug.cgi?id=199434
>+        <rdar://problem/52475140>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Disabled the tests that were passing for workaround. The workaround had
>+        to be roll out cause it is hanging Safari.
>+        * TestExpectations:
>+        * platform/ios-wk2/TestExpectations:
>+
> 2019-07-02  Saam Barati  <sbarati@apple.com>
> 
>         [WHLSL] Change whlsl-two-dimensional-array.html to not be flaky on AMD Radeon Pro GPUs
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 69382a915418b6e1b11e1280c73972db79708521..a407df24e2c3e673fef8d573f60e1ff3a59a753a 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -2204,6 +2204,7 @@ webkit.org/b/170122 http/tests/preload/single_download_preload_headers_charset.p
> ########################################
> ### START OF -disabled tests
> 
>+webkit.org/b/199431 accessibility/set-selected-text-range-after-newline.html [ Skip ]
> webkit.org/b/20871 js/garbage-collect-after-string-appends.html [ Skip ]
> webkit.org/b/58323 compositing/objects/composited-object-alignment.html [ Skip ]
> webkit.org/b/48454 compositing/tiling/huge-layer-resize.html [ Skip ]
>diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations
>index c071b80b884c914d5436adbcde3c9b48a9dedd20..80f9dda5e12d8f87482956f52cede2d318a052ef 100644
>--- a/LayoutTests/platform/ios-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-wk2/TestExpectations
>@@ -994,6 +994,7 @@ fast/forms/indeterminate-progress-inline-height.html [ Failure ]
> fast/forms/input-appearance-spinbutton.html [ Failure ]
> fast/replaced/border-radius-clip.html [ Failure ]
> accessibility/ios-simulator/press-fires-touch-events.html [ Skip ]
>+webkit.org/b/199431 accessibility/ios-simulator/set-selected-text-range-after-newline.html [ Skip ]
> 
> fast/text/combining-character-sequence-vertical.html [ ImageOnlyFailure ]
> fast/text/vertical-quotation-marks.html [ ImageOnlyFailure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 199434: 373381