Attachment 373378 Details for Bug 199432 – Patch

[patch] Patch

bug-199432-20190702203122.patch (text/plain), 1.86 KB, created by Simon Fraser (smfr) on 2019-07-02 20:31:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-07-02 20:31:23 PDT

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 247085
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3df5f88decfe9ab63edfb3c637070825a1669b52..7135a5fd59f27d587e6c1983b332ada02db4c825 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-07-02  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r246723): ScrollingTreeOverflowScrollProxyNode::m_overflowScrollingNodeID is uninitialized sometimes
>+        https://bugs.webkit.org/show_bug.cgi?id=199432
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        I noticed while debugging rdar://problem/52291642 that m_overflowScrollingNodeID was uninitialized in
>+        ScrollingTreeOverflowScrollProxyNode. This could lead to the wrong node being found by m_scrollingTree->nodeForID(),
>+        which could result in type confusion bugs.
>+        
>+        This can happen with negative z-order layers when we fail to find their related scrolling tree node
>+        on the first pass.
>+
>+        * page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h:
>+
> 2019-07-02  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         Assertion fires when animating the 'class' attribute of an SVG element
>diff --git a/Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h b/Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h
>index 4c712c6eddc3c85fdc43ec11e8fa9c1da7344745..2137bc52572902a4a453b9a19180644e0d0deb99 100644
>--- a/Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h
>+++ b/Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h
>@@ -50,7 +50,7 @@ protected:
> 
>     WEBCORE_EXPORT void dumpProperties(TextStream&, ScrollingStateTreeAsTextBehavior) const override;
> 
>-    ScrollingNodeID m_overflowScrollingNodeID;
>+    ScrollingNodeID m_overflowScrollingNodeID { 0 };
>     RetainPtr<CALayer> m_layer;
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199432: 373378