Attachment 373377 Details for Bug 199428 – Patch

[patch] Patch

bug-199428-20190703112557.patch (text/plain), 1.41 KB, created by Fujii Hironori on 2019-07-02 19:25:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-07-02 19:25:59 PDT

Size: 1.41 KB

patch

obsolete

>Subversion Revision: 247085
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 646f6e31927eb9b020d43bdf2ae26d34acded213..577976da6e7673e1757dab6b719b3ccb5215e627 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-07-02  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'
>+        https://bugs.webkit.org/show_bug.cgi?id=199428
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        _host.platform.build_version() returns None for all platform but mac.
>+
>+        * Scripts/webkitpy/test/main.py:
>+        (_supports_building_and_running_lldb_tests): Check is_mac().
>+
> 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Add build steps to Install Wpe and Gtk dependencies
>diff --git a/Tools/Scripts/webkitpy/test/main.py b/Tools/Scripts/webkitpy/test/main.py
>index f3bf2dafe39105be7c4097e6f2503df058a18513..37b309dc917ca214826d7e8876bf30468c49262d 100644
>--- a/Tools/Scripts/webkitpy/test/main.py
>+++ b/Tools/Scripts/webkitpy/test/main.py
>@@ -102,6 +102,8 @@ def main():
> 
> 
> def _supports_building_and_running_lldb_tests():
>+    if not _host.platform.is_mac():
>+        return False
>     # FIXME: Remove when test-lldb is in its own script
>     # https://bugs.webkit.org/show_bug.cgi?id=187916
>     return not _host.platform.build_version().startswith('19A')

Actions: View | Formatted Diff | Diff

Attachments on bug 199428: 373377