Attachment 373375 Details for Bug 199311 – Patch

[patch] Patch

bug-199311-20190703105151.patch (text/plain), 6.77 KB, created by Fujii Hironori on 2019-07-02 18:51:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-07-02 18:51:52 PDT

Size: 6.77 KB

patch

obsolete

>Subversion Revision: 247085
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 44a42bfc7a78ed91b8180bed37710ebba9bceb91..afbb47a0b9581276589d4949d292fa9aabbd7a49 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-07-02  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test
>+        https://bugs.webkit.org/show_bug.cgi?id=199311
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These tests are depending on platform font metrics. They were
>+        created for a Blink bug, doesn't seem useful for WebKit. Just
>+        removed them.
>+
>+        * imported/blink/animations/display-inline-style-adjust.html: Deleted.
>+        * legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html: Deleted.
>+        * platform/gtk/TestExpectations: Unmarked them.
>+        * platform/ios/TestExpectations: Ditto.
>+        * platform/wpe/TestExpectations: Ditto.
>+
> 2019-07-02  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         Assertion fires when animating the 'class' attribute of an SVG element
>diff --git a/LayoutTests/imported/blink/animations/display-inline-style-adjust-expected.html b/LayoutTests/imported/blink/animations/display-inline-style-adjust-expected.html
>deleted file mode 100644
>index c237fdef0e0ecd702930683ebc969248a760039b..0000000000000000000000000000000000000000
>--- a/LayoutTests/imported/blink/animations/display-inline-style-adjust-expected.html
>+++ /dev/null
>@@ -1,12 +0,0 @@
>-<!DOCTYPE html>
>-<style>
>-div {
>-  position: absolute;
>-  top: 4em;
>-  width: 400px;
>-}
>-</style>
>-
>-<div>
>-  <span>This sentence should span a single line.</span>
>-</div>
>diff --git a/LayoutTests/imported/blink/animations/display-inline-style-adjust.html b/LayoutTests/imported/blink/animations/display-inline-style-adjust.html
>deleted file mode 100644
>index baee87d9b0acd80763b5cc2e153e3982e5412053..0000000000000000000000000000000000000000
>--- a/LayoutTests/imported/blink/animations/display-inline-style-adjust.html
>+++ /dev/null
>@@ -1,21 +0,0 @@
>-<!DOCTYPE html>
>-<style>
>-@keyframes test {
>-  from { background-position: 0 0;}
>-  to { background-position: 1px 1px;}
>-}
>-div {
>-  position: absolute;
>-  top: 4em;
>-  width: 400px;
>-}
>-.animated {
>-  position: absolute;
>-  animation: test 1000s;
>-}
>-</style>
>-
>-<div>
>-  <span>This sentence shoul</span>
>-  <span class="animated">d span a single line.</span>
>-</div>
>diff --git a/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust-expected.html b/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust-expected.html
>deleted file mode 100644
>index 6a80d4445cd90559a8d702b0603a91a1868c1518..0000000000000000000000000000000000000000
>--- a/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust-expected.html
>+++ /dev/null
>@@ -1,12 +0,0 @@
>-<!DOCTYPE html>
>-<style>
>-div {
>-  position: absolute;
>-  top: 4em;
>-  width: 400px;
>-}
>-</style>
>-
>-<div>
>-  <span>This sentence should span a single line.</span>
>-</div>
>diff --git a/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html b/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html
>deleted file mode 100644
>index 16a4d0bb76b418cb0c756252aa44a515b1f1451f..0000000000000000000000000000000000000000
>--- a/LayoutTests/legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html
>+++ /dev/null
>@@ -1,21 +0,0 @@
>-<!DOCTYPE html>
>-<style>
>-@keyframes test {
>-  from { background-position: 0 0;}
>-  to { background-position: 1px 1px;}
>-}
>-div {
>-  position: absolute;
>-  top: 4em;
>-  width: 400px;
>-}
>-.animated {
>-  position: absolute;
>-  animation: test 1000s;
>-}
>-</style>
>-
>-<div>
>-  <span>This sentence shoul</span>
>-  <span class="animated">d span a single line.</span>
>-</div>
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 52f85dcee1ed4a9de15c2acb5d85cc914cc58f30..d748df12b5dad168d4447212e557fc933da6390d 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -3323,7 +3323,6 @@ webkit.org/b/168373 media/media-preload-no-delay-loadevent.html [ Failure ]
> 
> # [GTK] Some reftest fail with only one or two pixel differences in diff image
> webkit.org/b/168426 fast/multicol/columns-on-body.html [ ImageOnlyFailure ]
>-webkit.org/b/168426 legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
> webkit.org/b/168426 fast/html/details-comment-crash.html [ ImageOnlyFailure ]
> webkit.org/b/168426 svg/clip-path/clip-opacity.html [ ImageOnlyFailure ]
> 
>diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations
>index 914cca66b11d696ba434c6edf1cff76ca3fa7a6a..7f22fc2cac2f7585bc47993e994434f5885e1bfc 100644
>--- a/LayoutTests/platform/ios/TestExpectations
>+++ b/LayoutTests/platform/ios/TestExpectations
>@@ -2247,8 +2247,6 @@ imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
> legacy-animation-engine/imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
> imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
> legacy-animation-engine/imported/blink/animations/base-render-style-font-selector-version-assert.html [ Pass Timeout ]
>-imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
>-legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure Pass ]
> imported/blink/compositing/draws-content/canvas-simple-background.html [ ImageOnlyFailure Pass ]
> imported/blink/compositing/draws-content/webgl-simple-background.html [ ImageOnlyFailure Pass ]
> imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index b278800112b2a32bdc12e0640bc28382bda37339..4a1701cbe28169483eed36ba97a244e27a7f5e66 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -1348,7 +1348,6 @@ webkit.org/b/186100 css3/color-filters/color-filter-opacity.html [ ImageOnlyFail
> 
> webkit.org/b/186754 legacy-animation-engine/accessibility/transformed-bounds.html [ Failure ]
> webkit.org/b/186252 legacy-animation-engine/css3/filters/backdrop/animation.html [ Timeout ]
>-webkit.org/b/168426 legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html [ ImageOnlyFailure ]
> 
> webkit.org/b/187044 webanimations/opacity-animation-yields-compositing-span.html [ Failure ]
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199311: 373081 | 373093 | 373103 | 373106 | 373107 | 373110 | 373111 | 373215 | 373218 | 373219 | 373293 | 373296 | 373375