Attachment 373366 Details for Bug 199424 – patch

[patch] patch

a-backup.diff (text/plain), 2.41 KB, created by Saam Barati on 2019-07-02 15:43:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-07-02 15:43:28 PDT

Size: 2.41 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 247073)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-07-02  Saam Barati  <sbarati@apple.com>
>+
>+        [WHLSL] Change whlsl-two-dimensional-array.html to not be flaky on AMD Radeon Pro GPUs
>+        https://bugs.webkit.org/show_bug.cgi?id=199424
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webgpu/whlsl-two-dimensional-array.html:
>+
> 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Enhance support of aria-haspopup per ARIA 1.1 specification.
>Index: LayoutTests/webgpu/whlsl-two-dimensional-array.html
>===================================================================
>--- LayoutTests/webgpu/whlsl-two-dimensional-array.html	(revision 247034)
>+++ LayoutTests/webgpu/whlsl-two-dimensional-array.html	(working copy)
>@@ -8,20 +8,20 @@
> <script>
> const shaderSource = `
> void fill(thread float[10][] array, float[10] value) {
>-    for (uint i = 0; i < array.length; i++) {
>+    for (uint i = 0; i < array.length; i = i + 1) {
>         array[i] = value;
>     }
> }
> 
> void fill(thread float[] array, float value) {
>-    for (uint i = 0; i < array.length; i++) {
>+    for (uint i = 0; i < array.length; i = i + 1) {
>         array[i] = value;
>     }
> }
> 
> bool contains(thread float[10][] array, float value) {
>-    for (uint i = 0; i < array.length; i++) {
>-        for (uint j = 0; j < array[j].length; j++) {
>+    for (uint i = 0; i < array.length; i = i + 1) {
>+        for (uint j = 0; j < array[j].length; j = j + 1) {
>             if (array[i][j] != value)
>                 return false;
>         }
>@@ -30,7 +30,7 @@ bool contains(thread float[10][] array, 
> }
> 
> bool contains(thread float[] array, float value) {
>-    for (uint i = 0; i < array.length; i++) {
>+    for (uint i = 0; i < array.length; i = i + 1) {
>         if (array[i] != value)
>             return false;
>     }
>@@ -45,13 +45,13 @@ compute void computeShader(device int[] 
>     if (!contains(@array, 0))
>         return;
> 
>-    for (uint i = 0; i < array.length; ++i) {
>+    for (uint i = 0; i < array.length; i = i + 1) {
>         float[10] value;
>         fill(@value, float(i));
>         array[i] = value;
>     }
> 
>-    for (uint i = 0; i < array.length; ++i) {
>+    for (uint i = 0; i < array.length; i = i + 1) {
>         float[10] value = array[i];
>         if (!contains(@value, float(i)))
>             return;

Actions: View | Formatted Diff | Diff

Attachments on bug 199424: 373366