Attachment 373362 Details for Bug 199422 – Patch

[patch] Patch

bug-199422-20190702173907.patch (text/plain), 2.03 KB, created by Aakash Jain on 2019-07-02 14:39:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-07-02 14:39:08 PDT

Size: 2.03 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 247072)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-07-02  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Allow skipping uploading built product for few builders
>+        https://bugs.webkit.org/show_bug.cgi?id=199422
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (CompileWebKit.__init__): Added optional skipUpload parameter.
>+        (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
>+
> 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Enhance support of aria-haspopup per ARIA 1.1 specification.
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 247072)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -619,7 +619,8 @@ class CompileWebKit(shell.Compile):
>     haltOnFailure = False
>     command = ['perl', 'Tools/Scripts/build-webkit', WithProperties('--%(configuration)s')]
> 
>-    def __init__(self, **kwargs):
>+    def __init__(self, skipUpload=False, **kwargs):
>+        self.skipUpload = skipUpload
>         super(CompileWebKit, self).__init__(logEnviron=False, **kwargs)
> 
>     def start(self):
>@@ -650,7 +651,9 @@ class CompileWebKit(shell.Compile):
>             self.setProperty('patchFailedToBuild', True)
>             self.build.addStepsAfterCurrentStep([UnApplyPatchIfRequired(), CompileWebKitToT(), AnalyzeCompileWebKitResults()])
>         else:
>-            self.build.addStepsAfterCurrentStep([ArchiveBuiltProduct(), UploadBuiltProduct(), TransferToS3()])
>+            triggers = self.getProperty('triggers', None)
>+            if triggers or not self.skipUpload:
>+                self.build.addStepsAfterCurrentStep([ArchiveBuiltProduct(), UploadBuiltProduct(), TransferToS3()])
> 
>         return super(CompileWebKit, self).evaluateCommand(cmd)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199422: 373362