Attachment 373361 Details for Bug 199421 – Patch

[patch] Patch

bug-199421-20190702143248.patch (text/plain), 2.00 KB, created by youenn fablet on 2019-07-02 14:32:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-07-02 14:32:48 PDT

Size: 2.00 KB

patch

obsolete

>Subversion Revision: 246881
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f51863de66860f083c95e186cf73080c56868e52..c631acccbfba505480f5aa70a4d631519f3cce50 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-07-02  Youenn Fablet  <youenn@apple.com>
>+
>+        StorageManager does not need to be a WorkQueueMessageReceiver anymore
>+        https://bugs.webkit.org/show_bug.cgi?id=199421
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/WebStorage/StorageManager.h:
>+
> 2019-06-27  Youenn Fablet  <youenn@apple.com>
> 
>         Protect NetworkProcess::m_swServers from bad session IDs
>diff --git a/Source/WebKit/NetworkProcess/WebStorage/StorageManager.h b/Source/WebKit/NetworkProcess/WebStorage/StorageManager.h
>index c71cc68633d79584390cc7676bddc8db268de8dc..a7cda24e726b7a37d907dda5e91183d39cd0a13b 100644
>--- a/Source/WebKit/NetworkProcess/WebStorage/StorageManager.h
>+++ b/Source/WebKit/NetworkProcess/WebStorage/StorageManager.h
>@@ -45,7 +45,7 @@ class WebProcessProxy;
> 
> using GetValuesCallback = CompletionHandler<void(const HashMap<String, String>&)>;
> 
>-class StorageManager : public IPC::Connection::WorkQueueMessageReceiver {
>+class StorageManager : public ThreadSafeRefCounted<StorageManager> {
> public:
>     static Ref<StorageManager> create(const String& localStorageDirectory);
>     ~StorageManager();
>@@ -73,9 +73,8 @@ public:
> 
>     void getLocalStorageOriginDetails(Function<void(Vector<LocalStorageDatabaseTracker::OriginDetails>&&)>&& completionHandler);
> 
>-    // IPC::Connection::WorkQueueMessageReceiver.
>-    void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;
>-    void didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder>& replyEncoder) override;
>+    void didReceiveMessage(IPC::Connection&, IPC::Decoder&);
>+    void didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder>& replyEncoder);
> 
> private:
>     explicit StorageManager(const String& localStorageDirectory);

Actions: View | Formatted Diff | Diff

Attachments on bug 199421: 373361