WebKit Bugzilla
Attachment 373300 Details for
Bug 199216
: Enhance support of aria-haspopup per ARIA 1.1 specification.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199216-20190701220917.patch (text/plain), 2.12 KB, created by
Andres Gonzalez
on 2019-07-01 19:09:18 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Andres Gonzalez
Created:
2019-07-01 19:09:18 PDT
Size:
2.12 KB
patch
obsolete
>Subversion Revision: 247005 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 1fb5a9c54294f12ca63ebc28ff6539a358bb039e..ccaa8bdf461a9a16980f14dab5414e899a808458 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2019-07-01 Andres Gonzalez <andresg_22@apple.com> >+ >+ Enhance support of aria-haspopup per ARIA 1.1 specification. >+ https://bugs.webkit.org/show_bug.cgi?id=199216 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fix for test inspector/dom/getAccessibilityPropertiesForNode.html that >+ caught new bug introduced for comboboxes. >+ >+ * accessibility/AccessibilityObject.cpp: >+ (WebCore::AccessibilityObject::popupValue const): >+ > 2019-07-01 Carlos Garcia Campos <cgarcia@igalia.com> > > Unreviewed. Fix GTK build with GSTREAMER_GL disabled after r246710 >diff --git a/Source/WebCore/accessibility/AccessibilityObject.cpp b/Source/WebCore/accessibility/AccessibilityObject.cpp >index 61e525130c1c4614a8e5d1ac665a7e00affd6bbd..bbea694aab93bf64dbb2c9310769912fced01bc8 100644 >--- a/Source/WebCore/accessibility/AccessibilityObject.cpp >+++ b/Source/WebCore/accessibility/AccessibilityObject.cpp >@@ -2765,8 +2765,12 @@ String AccessibilityObject::popupValue() const > }); > > auto hasPopup = getAttribute(aria_haspopupAttr).convertToASCIILowercase(); >- if (hasPopup.isNull()) >+ if (hasPopup.isNull() || hasPopup.isEmpty()) { >+ // In ARIA 1.1, the implicit value for combobox became "listbox." >+ if (isComboBox()) >+ return "listbox"; > return "false"; >+ } > > if (allowedPopupValues->contains(hasPopup)) > return hasPopup; >@@ -2775,10 +2779,6 @@ String AccessibilityObject::popupValue() const > if (hasPopup == "true") > return "menu"; > >- // In ARIA 1.1, the implicit value for combobox became "listbox." >- if (isComboBox() && hasPopup.isEmpty()) >- return "listbox"; >- > // The spec states that "User agents must treat any value of aria-haspopup that is not > // included in the list of allowed values, including an empty string, as if the value > // false had been provided."
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199216
:
372892
|
372895
|
372899
|
372927
|
372997
|
373032
|
373193
|
373197
|
373300
|
373325