Attachment 373286 Details for Bug 199391 – Patch

[patch] Patch

bug-199391-20190701173233.patch (text/plain), 21.50 KB, created by Robin Morisset on 2019-07-01 17:32:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-07-01 17:32:33 PDT

Size: 21.50 KB

patch

obsolete

>Subversion Revision: 247013
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dfe9b814ab18e1de625bf675fd628d792a46da5d..50d7acd2741adb488a88079e0670a6ad0b37667a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,34 @@
>+2019-07-01  Robin Morisset  <rmorisset@apple.com>
>+
>+        [WHLSL] WHLSL::AST::Node is useless
>+        https://bugs.webkit.org/show_bug.cgi?id=199391
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It has no member, no non-trivial method, and we never access an AST node completely generically.
>+        So WHLSL::AST::Node can be removed, as a first step towards removing the virtual table pointer from most AST nodes (and avoiding a virtual destructor call at the end of the compiler).
>+
>+        No new test because there is no functional change.
>+
>+        * Modules/webgpu/WHLSL/AST/WHLSLAST.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLNamedType.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h: Renamed from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h.
>+        (WebCore::WHLSL::AST::replaceWith):
>+        * Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLType.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
>+        * Modules/webgpu/WHLSL/AST/WHLSLValue.h:
>+        * Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLParser.h:
>+        * Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
>+        * WebCore.xcodeproj/project.pbxproj:
>+
> 2019-07-01  Robin Morisset  <rmorisset@apple.com>
> 
>         [WHLSL] the initializer in VariableDeclaration should be a std::unique_ptr, not Optional<UniqueRef<..>>
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
>index f513c70759e2f73642ad52637565c4de42f8b70f..5a01e3f66c904c87727ba8870454b342fde3e81c 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
>@@ -69,7 +69,6 @@
> #include "WHLSLNamedType.h"
> #include "WHLSLNativeFunctionDeclaration.h"
> #include "WHLSLNativeTypeDeclaration.h"
>-#include "WHLSLNode.h"
> #include "WHLSLNullLiteral.h"
> #include "WHLSLNullLiteralType.h"
> #include "WHLSLNumThreadsFunctionAttribute.h"
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h
>index 2731ed110f828820c9cb675628b9b2e419fe0b36..168990b16cbf26a749c2e0ffc23095063edbaeee 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h
>@@ -28,7 +28,6 @@
> #if ENABLE(WEBGPU)
> 
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> 
> namespace WebCore {
> 
>@@ -36,7 +35,7 @@ namespace WHLSL {
> 
> namespace AST {
> 
>-class BaseFunctionAttribute : public Node {
>+class BaseFunctionAttribute {
> public:
>     BaseFunctionAttribute(Lexer::Token&& origin)
>         : m_origin(WTFMove(origin))
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h
>index dd2a665035f32328ee3ce212ce7b5bd8dc3a6f7e..3a9a7abad4a70f0e4fd99f79e35b48f29a26fbab 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h
>@@ -29,7 +29,6 @@
> 
> #include "WHLSLEntryPointType.h"
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> #include <wtf/Optional.h>
> 
> namespace WebCore {
>@@ -43,7 +42,7 @@ namespace AST {
> class FunctionDefinition;
> class UnnamedType;
> 
>-class BaseSemantic : public Node {
>+class BaseSemantic {
> public:
>     BaseSemantic(Lexer::Token&& origin)
>         : m_origin(WTFMove(origin))
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h
>index 66df1883dc2424d30a14547c3cc72f48f213b490..467de95a0d292445b32ee6993a2191a375eaedde 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h
>@@ -29,7 +29,6 @@
> 
> #include "WHLSLConstantExpression.h"
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> #include <wtf/Optional.h>
> #include <wtf/Vector.h>
> #include <wtf/text/WTFString.h>
>@@ -40,7 +39,7 @@ namespace WHLSL {
> 
> namespace AST {
> 
>-class EnumerationMember : public Node {
>+class EnumerationMember {
> public:
>     EnumerationMember(Lexer::Token&& origin, String&& name, Optional<ConstantExpression>&& value = WTF::nullopt)
>         : m_origin(WTFMove(origin))
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h
>index 52ab6a556d1fe53bdaf2d32e6584b71b6f566401..79ffa8805b9dc6384d1b16173af3e72407dcc0b3 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h
>@@ -30,7 +30,6 @@
> #include "WHLSLEntryPointType.h"
> #include "WHLSLFunctionAttribute.h"
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> #include "WHLSLSemantic.h"
> #include "WHLSLUnnamedType.h"
> #include "WHLSLVariableDeclaration.h"
>@@ -43,7 +42,7 @@ namespace WHLSL {
> 
> namespace AST {
> 
>-class FunctionDeclaration : public Node {
>+class FunctionDeclaration {
> public:
>     FunctionDeclaration(Lexer::Token&& origin, AttributeBlock&& attributeBlock, Optional<EntryPointType> entryPointType, UniqueRef<UnnamedType>&& type, String&& name, VariableDeclarations&& parameters, Optional<Semantic>&& semantic, bool isOperator)
>         : m_origin(WTFMove(origin))
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h
>index 8aa7c5e384b83883b688ab7e2ea0002de0afb35e..22a61ba1fc963877bef3e6028cf080c993231411 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h
>@@ -28,7 +28,6 @@
> #if ENABLE(WEBGPU)
> 
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> #include "WHLSLType.h"
> #include <wtf/text/WTFString.h>
> 
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h
>deleted file mode 100644
>index d6f7e823374c7885e34d420ba38e89b9590055c3..0000000000000000000000000000000000000000
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h
>+++ /dev/null
>@@ -1,66 +0,0 @@
>-/*
>- * Copyright (C) 2019 Apple Inc. All rights reserved.
>- *
>- * Redistribution and use in source and binary forms, with or without
>- * modification, are permitted provided that the following conditions
>- * are met:
>- * 1. Redistributions of source code must retain the above copyright
>- *    notice, this list of conditions and the following disclaimer.
>- * 2. Redistributions in binary form must reproduce the above copyright
>- *    notice, this list of conditions and the following disclaimer in the
>- *    documentation and/or other materials provided with the distribution.
>- *
>- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>- * THE POSSIBILITY OF SUCH DAMAGE.
>- */
>-
>-#pragma once
>-
>-#if ENABLE(WEBGPU)
>-
>-namespace WebCore {
>-
>-namespace WHLSL {
>-
>-namespace AST {
>-
>-class Node {
>-public:
>-    Node() = default;
>-
>-    virtual ~Node() = default;
>-
>-    explicit Node(const Node&) = default;
>-    Node(Node&&) = default;
>-
>-    Node& operator=(const Node&) = default;
>-    Node& operator=(Node&&) = default;
>-
>-private:
>-};
>-
>-template <typename New, typename Old, typename ...Args>
>-ALWAYS_INLINE New* replaceWith(Old& old, Args&&... args)
>-{
>-    static_assert(sizeof(New) <= sizeof(Old), "This is needed for the placement new below to not overwrite unowned memory.");
>-    void* location = &old;
>-    old.~Old();
>-    return new (location) New(std::forward<Args>(args)...);
>-}
>-
>-} // namespace AST
>-
>-}
>-
>-}
>-
>-#endif
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..ab6eefebe1a0a2020e41c10d2b31be1a56a01d34
>--- /dev/null
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h
>@@ -0,0 +1,47 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#if ENABLE(WEBGPU)
>+
>+namespace WebCore {
>+
>+namespace WHLSL {
>+
>+namespace AST {
>+
>+template <typename New, typename Old, typename ...Args>
>+ALWAYS_INLINE New* replaceWith(Old& old, Args&&... args)
>+{
>+    static_assert(sizeof(New) <= sizeof(Old), "This is needed for the placement new below to not overwrite unowned memory.");
>+    void* location = &old;
>+    old.~Old();
>+    return new (location) New(std::forward<Args>(args)...);
>+}
>+
>+} } } // namespace WebCore::WHLSL::AST
>+
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h
>index 8472f5c962c87cae0d7170ef438ed47dabdd039b..340c0c15947048f5cc999d1b34c7e7277a36a31c 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h
>@@ -28,7 +28,6 @@
> #if ENABLE(WEBGPU)
> 
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> #include "WHLSLQualifier.h"
> #include "WHLSLSemantic.h"
> #include "WHLSLType.h"
>@@ -40,7 +39,7 @@ namespace WHLSL {
> 
> namespace AST {
> 
>-class StructureElement : public Node {
>+class StructureElement {
> public:
>     StructureElement(Lexer::Token&& origin, Qualifiers&& qualifiers, UniqueRef<UnnamedType>&& type, String&& name, Optional<Semantic> semantic)
>         : m_origin(WTFMove(origin))
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h
>index c59e49646438f853ac908f8a63cc440d0d53b503..10ac4d196d562a0e6959f736494a5186784747be 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h
>@@ -27,7 +27,6 @@
> 
> #if ENABLE(WEBGPU)
> 
>-#include "WHLSLNode.h"
> #include <wtf/TypeCasts.h>
> 
> namespace WebCore {
>@@ -36,7 +35,7 @@ namespace WHLSL {
> 
> namespace AST {
> 
>-class Type : public Node {
>+class Type {
> public:
>     Type() = default;
> 
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h
>index ad87a0027dfe6c620cc5e616113f346f6c73317b..88688ac216fe511d90c205752fa189059966b0cf 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h
>@@ -29,7 +29,6 @@
> 
> #include "WHLSLLexer.h"
> #include "WHLSLNamedType.h"
>-#include "WHLSLNode.h"
> #include "WHLSLUnnamedType.h"
> #include <wtf/UniqueRef.h>
> #include <wtf/text/WTFString.h>
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
>index e1badbdc600ac793fe5696efac480212f917af68..9071099b24ea23ec8990cd201d5642497c0b7327 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
>@@ -28,7 +28,6 @@
> #if ENABLE(WEBGPU)
> 
> #include "WHLSLLexer.h"
>-#include "WHLSLNode.h"
> #include "WHLSLType.h"
> #include <wtf/UniqueRef.h>
> #include <wtf/text/WTFString.h>
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h
>index c4119b1ee1b1b1b6488dbfeb37bd3921aa48701f..4179d3d031dbc856e8bbee3e4b112bf5573fdcb6 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h
>@@ -27,15 +27,13 @@
> 
> #if ENABLE(WEBGPU)
> 
>-#include "WHLSLNode.h"
>-
> namespace WebCore {
> 
> namespace WHLSL {
> 
> namespace AST {
> 
>-class Value : public Node {
>+class Value {
> public:
>     Value(Lexer::Token&& origin)
>         : m_origin(WTFMove(origin))
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
>index 016b8550cb2bb9903163901640aa29cb8e75b1f4..00674788fdaa14b183185684b454de62d8a8f5c4 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
>@@ -39,6 +39,7 @@
> #include "WHLSLNameContext.h"
> #include "WHLSLProgram.h"
> #include "WHLSLPropertyAccessExpression.h"
>+#include "WHLSLReplaceWith.h"
> #include "WHLSLResolveOverloadImpl.h"
> #include "WHLSLReturn.h"
> #include "WHLSLScopedSetAdder.h"
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
>index 276e1c5e546b6326abfe20430bbc3202158784d3..43811e07b8c4de54a4bc072fdfd12cadf8b3290f 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
>@@ -63,7 +63,6 @@
> #include "WHLSLMakePointerExpression.h"
> #include "WHLSLNativeFunctionDeclaration.h"
> #include "WHLSLNativeTypeDeclaration.h"
>-#include "WHLSLNode.h"
> #include "WHLSLNullLiteral.h"
> #include "WHLSLNumThreadsFunctionAttribute.h"
> #include "WHLSLPointerType.h"
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp
>index fc754bbb2fbbaaf6059c68349847afc2b0c96838..e5f25c1f635bb2b6675213479d0b5fd5503ad536 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp
>@@ -30,6 +30,7 @@
> 
> #include "WHLSLAST.h"
> #include "WHLSLASTDumper.h"
>+#include "WHLSLReplaceWith.h"
> #include "WHLSLVisitor.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp
>index 17fb0954c7ad8ffb19291e477daafe8c5dd05cfc..253439e3b51f7848e34eda9056cbab483f8398f5 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp
>@@ -39,6 +39,7 @@
> #include "WHLSLMakePointerExpression.h"
> #include "WHLSLPointerType.h"
> #include "WHLSLReadModifyWriteExpression.h"
>+#include "WHLSLReplaceWith.h"
> #include "WHLSLVariableDeclaration.h"
> #include "WHLSLVariableReference.h"
> #include "WHLSLVisitor.h"
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index 5c849c758b0fbe04895deb6af2894fb28f889051..83814bf9c8fae26ce0b14c000c4dfabadce2087a 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -857,7 +857,7 @@
> 		2E4346510F546A8200B0F1BA /* WorkerObjectProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E43463F0F546A8200B0F1BA /* WorkerObjectProxy.h */; };
> 		2E4346530F546A8200B0F1BA /* WorkerRunLoop.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E4346410F546A8200B0F1BA /* WorkerRunLoop.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		2E4346550F546A8200B0F1BA /* WorkerThread.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E4346430F546A8200B0F1BA /* WorkerThread.h */; settings = {ATTRIBUTES = (Private, ); }; };
>-		2E75841E12779ADA0062628B /* FileReaderLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E75841B12779ADA0062628B /* FileReaderLoader.h */; settings = {ATTRIBUTES = (Private, ); };};
>+		2E75841E12779ADA0062628B /* FileReaderLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E75841B12779ADA0062628B /* FileReaderLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		2E75841F12779ADA0062628B /* FileReaderLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E75841C12779ADA0062628B /* FileReaderLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		2E94F43C119207DA00B7F75D /* JSFileReader.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E94F43A119207DA00B7F75D /* JSFileReader.h */; };
> 		2E9B5D8F1B66A94E008C6A24 /* WheelEventDeltaFilterMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E9B5D8E1B66A94E008C6A24 /* WheelEventDeltaFilterMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
>@@ -7128,6 +7128,7 @@
> 		33503C9F10179AD7003B47E1 /* JSNotification.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSNotification.cpp; sourceTree = "<group>"; };
> 		33503CA010179AD7003B47E1 /* JSNotification.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSNotification.h; sourceTree = "<group>"; };
> 		33503CC61017A1B1003B47E1 /* Notification.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Notification.cpp; sourceTree = "<group>"; };
>+		3351F70B22CAD8DA0015B40D /* WHLSLReplaceWith.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLReplaceWith.h; sourceTree = "<group>"; };
> 		35C74FD3228A1912000C21A0 /* CSSGridIntegerRepeatValue.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = CSSGridIntegerRepeatValue.cpp; sourceTree = "<group>"; };
> 		35C74FD7228A19A6000C21A0 /* CSSGridIntegerRepeatValue.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CSSGridIntegerRepeatValue.h; sourceTree = "<group>"; };
> 		3662F984047CEDBE5DDDAFAA /* RenderMathMLMenclose.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderMathMLMenclose.cpp; sourceTree = "<group>"; };
>@@ -13326,7 +13327,6 @@
> 		C21BF72121CD89DE00227979 /* WHLSLNumThreadsFunctionAttribute.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLNumThreadsFunctionAttribute.h; sourceTree = "<group>"; };
> 		C21BF72221CD89DF00227979 /* WHLSLBuiltInSemantic.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLBuiltInSemantic.h; sourceTree = "<group>"; };
> 		C21BF72321CD89E100227979 /* WHLSLNativeFunctionDeclaration.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLNativeFunctionDeclaration.h; sourceTree = "<group>"; };
>-		C21BF72421CD89E100227979 /* WHLSLNode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLNode.h; sourceTree = "<group>"; };
> 		C21BF72521CD89E200227979 /* WHLSLArrayReferenceType.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLArrayReferenceType.h; sourceTree = "<group>"; };
> 		C21BF72621CD89E300227979 /* WHLSLEnumerationMember.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLEnumerationMember.h; sourceTree = "<group>"; };
> 		C21BF72721CD89E400227979 /* WHLSLStructureDefinition.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLStructureDefinition.h; sourceTree = "<group>"; };
>@@ -17130,7 +17130,6 @@
> 				1C33277121CF0BE1000DC9F2 /* WHLSLNamedType.h */,
> 				C21BF72321CD89E100227979 /* WHLSLNativeFunctionDeclaration.h */,
> 				C21BF72A21CD89E700227979 /* WHLSLNativeTypeDeclaration.h */,
>-				C21BF72421CD89E100227979 /* WHLSLNode.h */,
> 				C21BF70721CD89C800227979 /* WHLSLNullLiteral.h */,
> 				1CB69B3A21DF0403006E846A /* WHLSLNullLiteralType.cpp */,
> 				1CB69B3621DED657006E846A /* WHLSLNullLiteralType.h */,
>@@ -17172,6 +17171,7 @@
> 				C21BF71421CD89D300227979 /* WHLSLVariableDeclarationsStatement.h */,
> 				C21BF71321CD89D200227979 /* WHLSLVariableReference.h */,
> 				C21BF70421CD89C600227979 /* WHLSLWhileLoop.h */,
>+				3351F70B22CAD8DA0015B40D /* WHLSLReplaceWith.h */,
> 			);
> 			path = AST;
> 			sourceTree = "<group>";

Actions: View | Formatted Diff | Diff

Attachments on bug 199391: 373286 | 373410 | 373411 | 373412