Attachment 373284 Details for Bug 199326 – Patch

[patch] Patch

bug-199326-20190701171532.patch (text/plain), 5.00 KB, created by Priyanka on 2019-07-01 17:15:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Priyanka

Created: 2019-07-01 17:15:33 PDT

Size: 5.00 KB

patch

obsolete

>Subversion Revision: 247025
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 2c148bdb2f0c7c4c6f84237daf29e68a3c8d359d..ac49943efa951a87cee0143143bd17027d49f543 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,24 @@
>+2019-06-28  Priyanka Agarwal  <pagarwal999@apple.com>
>+
>+        Allow Clients to Add Fields to the AutoFillContext Dictionary
>+        https://bugs.webkit.org/show_bug.cgi?id=199326
>+        rdar://problem/42816957
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/_WKInputDelegate.h:
>+        Added function declaration for function which returns additional dictionary for autofillcontext
>+
>+        * UIProcess/ios/WKContentViewInteraction.h:
>+        Created dictionary for additional autofillcontext
>+ 
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
>+        Populating additional dictionary for autofillcontext
>+
>+        (-[WKContentView _autofillContext]):
>+        Adding new dictionary to the returned autofillcontext
>+
> 2019-07-01  Alex Christensen  <achristensen@webkit.org>
> 
>         Deprecate but still call _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h b/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h
>index 1665279d366ebb20fdcb56d2861126f4a317d14b..1d3044e327a8a900c2fda06523b73cfa22a91c5b 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h
>@@ -55,6 +55,8 @@ typedef NS_ENUM(NSInteger, _WKFocusStartsInputSessionPolicy) {
> - (void)_webView:(WKWebView *)webView willStartInputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
> - (BOOL)_webView:(WKWebView *)webView focusRequiresStrongPasswordAssistance:(id <_WKFocusedElementInfo>)info WK_API_AVAILABLE(ios(12.0));
> 
>+- (NSDictionary<id, NSString *> *)_webViewAdditionalContextForStrongPasswordAssistance:(WKWebView *)webView WK_API_AVAILABLE(ios(WK_IOS_TBA));
>+
> - (BOOL)_webView:(WKWebView *)webView shouldRevealFocusOverlayForInputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
> - (CGFloat)_webView:(WKWebView *)webView focusedElementContextViewHeightForFittingSize:(CGSize)fittingSize inputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
> - (UIView *)_webView:(WKWebView *)webView focusedElementContextViewForInputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>index 438e4b18630ca709ea313b9464e75c5491714496..c5081c7e8fe3ded60883ab6bcc247af01ffa7de3 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>@@ -350,6 +350,8 @@ struct WKAutoCorrectionData {
>     CompletionHandler<void(WebCore::DOMPasteAccessResponse)> _domPasteRequestHandler;
>     BlockPtr<void(UIWKAutocorrectionContext *)> _pendingAutocorrectionContextHandler;
> 
>+    NSDictionary *_additionalContextForStrongPasswordAssistance;
>+
> #if ENABLE(DATA_INTERACTION)
>     WebKit::DragDropInteractionState _dragDropInteractionState;
>     RetainPtr<UIDragInteraction> _dragInteraction;
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 0fc3e4368868f4af0c8fcb45026b4af9d9458b5c..b0cbe99ada6e20dc702b400931168f2585667dc8 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -5219,6 +5219,11 @@ - (void)_elementDidFocus:(const WebKit::FocusedElementInformation&)information u
>     if ([inputDelegate respondsToSelector:@selector(_webView:focusRequiresStrongPasswordAssistance:)])
>         _focusRequiresStrongPasswordAssistance = [inputDelegate _webView:_webView focusRequiresStrongPasswordAssistance:focusedElementInfo.get()];
> 
>+    if ([inputDelegate respondsToSelector:@selector(_webViewAdditionalContextForStrongPasswordAssistance:)])
>+        _additionalContextForStrongPasswordAssistance = [inputDelegate _webViewAdditionalContextForStrongPasswordAssistance:_webView];
>+    else
>+        _additionalContextForStrongPasswordAssistance = @{ };
>+
>     bool delegateImplementsWillStartInputSession = [inputDelegate respondsToSelector:@selector(_webView:willStartInputSession:)];
>     bool delegateImplementsDidStartInputSession = [inputDelegate respondsToSelector:@selector(_webView:didStartInputSession:)];
> 
>@@ -6649,7 +6654,7 @@ - (NSDictionary *)_autofillContext
>         return nil;
> 
>     if (provideStrongPasswordAssistance)
>-        return @{ @"_automaticPasswordKeyboard" : @YES };
>+        return @{ @"_automaticPasswordKeyboard" : @YES, @"strongPasswordAdditionalContext": _additionalContextForStrongPasswordAssistance};
> 
>     NSURL *platformURL = _focusedElementInformation.representingPageURL;
>     if (platformURL)

Actions: View | Formatted Diff | Diff

Attachments on bug 199326: 373133 | 373157 | 373158 | 373284 | 374748 | 374761 | 374763 | 374800 | 374804 | 374812 | 374833