WebKit Bugzilla
Attachment 373272 Details for
Bug 199384
: [iOS 13] editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html fails on trunk
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Slightly more succint.
bug-199384-20190701150504.patch (text/plain), 2.40 KB, created by
Wenson Hsieh
on 2019-07-01 15:05:04 PDT
(
hide
)
Description:
Slightly more succint.
Filename:
MIME Type:
Creator:
Wenson Hsieh
Created:
2019-07-01 15:05:04 PDT
Size:
2.40 KB
patch
obsolete
>Subversion Revision: 247013 >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 0a4eeb9e6881e34e2ad055c99731e3285adcd5fa..9f694f93bf7e0d297180c0be77f44fb5cddbfc9b 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,16 @@ >+2019-07-01 Wenson Hsieh <wenson_hsieh@apple.com> >+ >+ [iOS 13] editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html fails on trunk >+ https://bugs.webkit.org/show_bug.cgi?id=199384 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Adjust this test to show the callout menu by tapping on the caret rect, rather than the center of the editable >+ area. Currently, tapping the center of the editable area twice results in a double tap, which fails to trigger >+ the callout bar. >+ >+ * editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html: >+ > 2019-07-01 Wenson Hsieh <wenson_hsieh@apple.com> > > iOS: REGRESSION(async scroll): Caret doesn't scroll when scrolling textarea >diff --git a/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html b/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html >index 0a2fb95a5dfa4c247adfab45be1f11b5b59cbf88..a118033d120a5e99fcc52ad694d19dec26d70acd 100644 >--- a/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html >+++ b/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html >@@ -41,6 +41,15 @@ addEventListener("mousedown", recordEvent); > addEventListener("mousemove", recordEvent); > addEventListener("mouseup", recordEvent); > >+async function waitForCaretToAppear() >+{ >+ while (true) { >+ const rect = await UIHelper.getUICaretViewRect(); >+ if (rect && rect.top && rect.left && rect.width > 0 && rect.height > 0) >+ return rect; >+ } >+} >+ > async function waitForSelectionToAppear() > { > while (true) { >@@ -63,7 +72,8 @@ addEventListener("load", async () => { > debug("\nAttempting to show the callout bar."); > const editor = document.querySelector(".editor"); > await UIHelper.activateElementAndWaitForInputSession(editor); >- await UIHelper.activateElement(editor); >+ const [caretX, caretY] = midPointOfRect(await waitForCaretToAppear()); >+ await UIHelper.activateAt(caretX, caretY); > await UIHelper.waitForMenuToShow(); > testPassed("Displayed the callout bar."); >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199384
:
373271
| 373272