Attachment 373271 Details for Bug 199384 – Patch

[patch] Patch

bug-199384-20190701150204.patch (text/plain), 2.44 KB, created by Wenson Hsieh on 2019-07-01 15:02:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-07-01 15:02:05 PDT

Size: 2.44 KB

patch

obsolete

>Subversion Revision: 247013
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 0a4eeb9e6881e34e2ad055c99731e3285adcd5fa..9f694f93bf7e0d297180c0be77f44fb5cddbfc9b 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS 13] editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html fails on trunk
>+        https://bugs.webkit.org/show_bug.cgi?id=199384
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adjust this test to show the callout menu by tapping on the caret rect, rather than the center of the editable
>+        area. Currently, tapping the center of the editable area twice results in a double tap, which fails to trigger
>+        the callout bar.
>+
>+        * editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html:
>+
> 2019-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         iOS: REGRESSION(async scroll): Caret doesn't scroll when scrolling textarea
>diff --git a/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html b/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html
>index 0a2fb95a5dfa4c247adfab45be1f11b5b59cbf88..d7a6dceaa25a33024bdac0bdfbf1d4034acdb9cf 100644
>--- a/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html
>+++ b/LayoutTests/editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html
>@@ -41,6 +41,15 @@ addEventListener("mousedown", recordEvent);
> addEventListener("mousemove", recordEvent);
> addEventListener("mouseup", recordEvent);
> 
>+async function waitForCaretToAppear()
>+{
>+    while (true) {
>+        const rect = await UIHelper.getUICaretViewRect();
>+        if (rect && rect.top && rect.left && rect.width > 0 && rect.height > 0)
>+            return rect;
>+    }
>+}
>+
> async function waitForSelectionToAppear()
> {
>     while (true) {
>@@ -63,7 +72,8 @@ addEventListener("load", async () => {
>     debug("\nAttempting to show the callout bar.");
>     const editor = document.querySelector(".editor");
>     await UIHelper.activateElementAndWaitForInputSession(editor);
>-    await UIHelper.activateElement(editor);
>+    const caretRect = await waitForCaretToAppear();
>+    await UIHelper.activateAt(caretRect.left + caretRect.width / 2, caretRect.top + caretRect.height / 2);
>     await UIHelper.waitForMenuToShow();
>     testPassed("Displayed the callout bar.");
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199384: 373271 | 373272