Attachment 373267 Details for Bug 199383 – Patch

[patch] Patch

bug-199383-20190701143337.patch (text/plain), 2.91 KB, created by Chris Dumez on 2019-07-01 14:33:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-07-01 14:33:38 PDT

Size: 2.91 KB

patch

obsolete

>Subversion Revision: 246837
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index eb96a892b5a73e7cf668284f3ee83f8306e42c9e..f4b40302ce635805e936f371d6d985f0eb9f8afa 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-01  Chris Dumez  <cdumez@apple.com>
>+
>+        Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540
>+        https://bugs.webkit.org/show_bug.cgi?id=199383
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebProcessLifetimeObserver.h:
>+        (WebKit::WebProcessLifetimeObserver::webProcessDidCloseConnection):
>+        * UIProcess/WebProcessLifetimeTracker.cpp:
>+        (WebKit::WebProcessLifetimeTracker::addObserver):
>+        (WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
>+
> 2019-07-01  Chris Dumez  <cdumez@apple.com>
> 
>         StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
>diff --git a/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h b/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h
>index 66939734561e4201a20f42a366ddd02a44704e95..49cbffb8494008a29ad90f2b27faff8c1e40a618 100644
>--- a/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h
>+++ b/Source/WebKit/UIProcess/WebProcessLifetimeObserver.h
>@@ -53,12 +53,10 @@ public:
> private:
>     friend class WebProcessLifetimeTracker;
> 
>-    virtual void webPageWasAdded(WebPageProxy&) { }
>     virtual void webProcessWillOpenConnection(WebProcessProxy&, IPC::Connection&) { }
>     virtual void webPageWillOpenConnection(WebPageProxy&, IPC::Connection&) { }
>     virtual void webPageDidCloseConnection(WebPageProxy&, IPC::Connection&) { }
>     virtual void webProcessDidCloseConnection(WebProcessProxy&, IPC::Connection&) { }
>-    virtual void webPageWasInvalidated(WebPageProxy&) { }
> 
>     HashCountedSet<WebProcessProxy*> m_processes;
> };
>diff --git a/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp b/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp
>index 71a0a5b25abe0bc1bd388cf07952c72a87102073..3a508e132321a70caac079c10975291655d831b6 100644
>--- a/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessLifetimeTracker.cpp
>@@ -47,8 +47,6 @@ void WebProcessLifetimeTracker::addObserver(WebProcessLifetimeObserver& observer
> 
>     m_observers.add(&observer);
> 
>-    observer.webPageWasAdded(m_webPageProxy);
>-
>     if (processIsRunning(m_webPageProxy.process()))
>         observer.addWebPage(m_webPageProxy, m_webPageProxy.process());
> }
>@@ -74,11 +72,8 @@ void WebProcessLifetimeTracker::pageWasInvalidated()
>     if (!processIsRunning(m_webPageProxy.process()))
>         return;
> 
>-    for (auto& observer : m_observers) {
>+    for (auto& observer : m_observers)
>         observer->removeWebPage(m_webPageProxy, m_webPageProxy.process());
>-
>-        observer->webPageWasInvalidated(m_webPageProxy);
>-    }
> }
> 
> bool WebProcessLifetimeTracker::processIsRunning(WebProcessProxy& process)

Actions: View | Formatted Diff | Diff

Attachments on bug 199383: 373267