Attachment 373266 Details for Bug 199382 – Patch

[patch] Patch

bug-199382-20190701143331.patch (text/plain), 1.91 KB, created by zalan on 2019-07-01 14:33:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-07-01 14:33:31 PDT

Size: 1.91 KB

patch

obsolete

>Subversion Revision: 247013
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index fb36b4877b8486b95317e51d80788fda076a6533..c33d035e248c814fa56b32338c80f1912adf440a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-01  Zalan Bujtas  <zalan@apple.com>
>+
>+        [Text autosizing] [iPadOS] AutosizeStatus::idempotentTextSize returns the computed font size in certain cases.
>+        https://bugs.webkit.org/show_bug.cgi?id=199382
>+        <rdar://problem/52483097>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adjust the font size on the style only when the autosized value is different from the computed value. 
>+
>+        * css/StyleResolver.cpp:
>+        (WebCore::StyleResolver::adjustRenderStyleForTextAutosizing):
>+
> 2019-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         iOS: REGRESSION(async scroll): Caret doesn't scroll when scrolling textarea
>diff --git a/Source/WebCore/css/StyleResolver.cpp b/Source/WebCore/css/StyleResolver.cpp
>index 15bfbe85a9e289676a20335e787774b3d7372245..0a1463286379e9e8012bd8a4f65f2852364e43be 100644
>--- a/Source/WebCore/css/StyleResolver.cpp
>+++ b/Source/WebCore/css/StyleResolver.cpp
>@@ -913,11 +913,13 @@ void StyleResolver::adjustRenderStyleForTextAutosizing(RenderStyle& style, const
>     auto fontDescription = style.fontDescription();
>     auto initialComputedFontSize = fontDescription.computedSize(); 
>     auto adjustedFontSize = AutosizeStatus::idempotentTextSize(fontDescription.specifiedSize(), initialScale);
>+    if (initialComputedFontSize == adjustedFontSize)
>+        return;
>+
>     fontDescription.setComputedSize(adjustedFontSize);
>     style.setFontDescription(WTFMove(fontDescription));
>     style.fontCascade().update(&document().fontSelector());
>-    if (initialComputedFontSize != adjustedFontSize)
>-        adjustLineHeightIfNeeded(adjustedFontSize);
>+    adjustLineHeightIfNeeded(adjustedFontSize);
> }
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199382: 373266