Attachment 373263 Details for Bug 199379 – Patch

[patch] Patch

bug-199379-20190701141257.patch (text/plain), 1.62 KB, created by Chris Dumez on 2019-07-01 14:12:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-07-01 14:12:58 PDT

Size: 1.62 KB

patch

obsolete

>Subversion Revision: 246837
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 0b692e71fc4dd6bb1949f7b33aa2da7a177a29c3..eb96a892b5a73e7cf668284f3ee83f8306e42c9e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-07-01  Chris Dumez  <cdumez@apple.com>
>+
>+        StorageManager::SessionStorageNamespace::allowedConnections() should not copy the HashSet
>+        https://bugs.webkit.org/show_bug.cgi?id=199379
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This was pretty inefficient.
>+
>+        * NetworkProcess/WebStorage/StorageManager.cpp:
>+        (WebKit::StorageManager::SessionStorageNamespace::allowedConnections const):
>+
> 2019-06-26  Zalan Bujtas  <zalan@apple.com>
> 
>         [ContentChangeObserver] Dispatch synthetic mouse event asynchronously in completePendingSyntheticClickForContentChangeObserver
>diff --git a/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp b/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp
>index 50fde90d615ed58896015c69a2b09152fd2fb27b..eb9a2c32e4fcdb6fa097abb94f9462ecc12859ba 100644
>--- a/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp
>+++ b/Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp
>@@ -417,7 +417,7 @@ public:
> 
>     bool isEmpty() const { return m_storageAreaMap.isEmpty(); }
> 
>-    HashSet<IPC::Connection::UniqueID> allowedConnections() const { return m_allowedConnections; }
>+    const HashSet<IPC::Connection::UniqueID>& allowedConnections() const { return m_allowedConnections; }
>     void addAllowedConnection(IPC::Connection::UniqueID);
>     void removeAllowedConnection(IPC::Connection::UniqueID);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199379: 373263