Attachment 373262 Details for Bug 196053 – For the bots

[patch] For the bots

ForTheBots.patch (text/plain), 1.95 KB, created by Daniel Bates on 2019-07-01 14:07:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-07-01 14:07:50 PDT

Size: 1.95 KB

patch

obsolete

>From e8a6ab21fde55768919f13f1cb64db8f0b98a742 Mon Sep 17 00:00:00 2001
>From: Daniel Bates <dabates@apple.com>
>Date: Mon, 1 Jul 2019 14:04:14 -0700
>Subject: [PATCH] For the bots
>
>---
> Source/WebCore/html/HTMLIFrameElement.h            | 4 ----
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm | 3 +++
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/Source/WebCore/html/HTMLIFrameElement.h b/Source/WebCore/html/HTMLIFrameElement.h
>index 08d92c83629..8dbf068617d 100644
>--- a/Source/WebCore/html/HTMLIFrameElement.h
>+++ b/Source/WebCore/html/HTMLIFrameElement.h
>@@ -50,10 +50,6 @@ public:
> private:
>     HTMLIFrameElement(const QualifiedName&, Document&);
> 
>-#if PLATFORM(IOS_FAMILY)
>-    bool isKeyboardFocusable(KeyboardEvent*) const final { return false; }
>-#endif
>-
>     void parseAttribute(const QualifiedName&, const AtomString&) final;
>     bool isPresentationAttribute(const QualifiedName&) const final;
>     void collectStyleForPresentationAttribute(const QualifiedName&, const AtomString&, MutableStyleProperties&) final;
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index bf8c2d98e79..efceb345e3a 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -86,6 +86,7 @@
> #import <WebCore/HTMLElement.h>
> #import <WebCore/HTMLElementTypeHelpers.h>
> #import <WebCore/HTMLFormElement.h>
>+#import <WebCore/HTMLIframeElement.h>
> #import <WebCore/HTMLImageElement.h>
> #import <WebCore/HTMLInputElement.h>
> #import <WebCore/HTMLLabelElement.h>
>@@ -2452,6 +2453,8 @@ static inline bool isAssistableElement(Element& node)
> #endif
>         return inputElement.isTextField() || inputElement.isDateField() || inputElement.isDateTimeLocalField() || inputElement.isMonthField() || inputElement.isTimeField();
>     }
>+    if (is<HTMLIFrameElement>(node))
>+        return false;
>     return node.isContentEditable();
> }
> 
>-- 
>2.21.0 (Apple Git-120)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 196053: 373262 | 373270 | 373336