Attachment 373186 Details for Bug 199195 – Patch

[patch] Patch

bug-199195-20190629214712.patch (text/plain), 2.93 KB, created by Per Arne Vollan on 2019-06-29 21:47:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2019-06-29 21:47:13 PDT

Size: 2.93 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 246952)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2019-06-29  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Perform less work when a pre-warmed WebProcess is suspended or resumed.
>+        https://bugs.webkit.org/show_bug.cgi?id=199195
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Return early from WebProcess::actualPrepareToSuspend and WebProcess::processDidResume
>+        if this is a pre-warmed process. This is a confirmed improvement in page load time.
>+
>+        * WebProcess/WebProcess.cpp:
>+        (WebKit::WebProcess::actualPrepareToSuspend):
>+        (WebKit::WebProcess::cancelPrepareToSuspend):
>+        (WebKit::WebProcess::processDidResume):
>+
> 2019-06-28  Brent Fulgham  <bfulgham@apple.com>
> 
>         Revise WebContent sandbox based on seed feedback
>Index: Source/WebKit/WebProcess/WebProcess.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebProcess.cpp	(revision 246952)
>+++ Source/WebKit/WebProcess/WebProcess.cpp	(working copy)
>@@ -1471,6 +1471,14 @@ void WebProcess::actualPrepareToSuspend(
>     SetForScope<bool> suspensionScope(m_isSuspending, true);
>     m_processIsSuspended = true;
> 
>+    if (m_processType == ProcessType::PrewarmedWebContent) {
>+        if (shouldAcknowledgeWhenReadyToSuspend == ShouldAcknowledgeWhenReadyToSuspend::Yes) {
>+            RELEASE_LOG(ProcessSuspension, "%p - WebProcess::actualPrepareToSuspend() Sending ProcessReadyToSuspend IPC message", this);
>+            parentProcessConnection()->send(Messages::WebProcessProxy::ProcessReadyToSuspend(), 0);
>+        }
>+        return;
>+    }
>+
> #if ENABLE(VIDEO)
>     suspendAllMediaBuffering();
>     if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
>@@ -1527,6 +1535,9 @@ void WebProcess::cancelPrepareToSuspend(
> 
>     m_processIsSuspended = false;
> 
>+    if (m_processType == ProcessType::PrewarmedWebContent)
>+        return;
>+
>     unfreezeAllLayerTrees();
> 
> #if PLATFORM(IOS_FAMILY)
>@@ -1603,6 +1614,9 @@ void WebProcess::processDidResume()
> 
>     m_processIsSuspended = false;
> 
>+    if (m_processType == ProcessType::PrewarmedWebContent)
>+        return;
>+
>     cancelMarkAllLayersVolatile();
>     unfreezeAllLayerTrees();
>     
>Index: Source/WebKit/WebProcess/WebProcess.h
>===================================================================
>--- Source/WebKit/WebProcess/WebProcess.h	(revision 246952)
>+++ Source/WebKit/WebProcess/WebProcess.h	(working copy)
>@@ -546,10 +546,8 @@ private:
>     WebCore::RegistrableDomain m_registrableDomain;
> #endif
> 
>-#if PLATFORM(COCOA)
>     enum class ProcessType { Inspector, ServiceWorker, PrewarmedWebContent, CachedWebContent, WebContent };
>     ProcessType m_processType { ProcessType::WebContent };
>-#endif
> 
>     HashMap<WebCore::UserGestureToken *, uint64_t> m_userGestureTokens;
>

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199195: 372848 | 372853 | 373132 | 373134 | 373186 | 373234