WebKit Bugzilla
Attachment 373134 Details for
Bug 199195
: Perform less work when a pre-warmed WebProcess is suspended or resumed.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199195-20190628110950.patch (text/plain), 2.43 KB, created by
Per Arne Vollan
on 2019-06-28 11:09:51 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Per Arne Vollan
Created:
2019-06-28 11:09:51 PDT
Size:
2.43 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 246928) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,18 @@ >+2019-06-28 Per Arne Vollan <pvollan@apple.com> >+ >+ Perform less work when a pre-warmed WebProcess is suspended or resumed. >+ https://bugs.webkit.org/show_bug.cgi?id=199195 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Return early from WebProcess::actualPrepareToSuspend and WebProcess::processDidResume >+ if this is a pre-warmed process. This is a confirmed improvement in page load time. >+ >+ * WebProcess/WebProcess.cpp: >+ (WebKit::WebProcess::actualPrepareToSuspend): >+ (WebKit::WebProcess::cancelPrepareToSuspend): >+ (WebKit::WebProcess::processDidResume): >+ > 2019-06-28 Jer Noble <jer.noble@apple.com> > > Add new -[WKWebView _closeAllMediaPresentations] SPI >Index: Source/WebKit/WebProcess/WebProcess.cpp >=================================================================== >--- Source/WebKit/WebProcess/WebProcess.cpp (revision 246809) >+++ Source/WebKit/WebProcess/WebProcess.cpp (working copy) >@@ -1471,6 +1471,16 @@ void WebProcess::actualPrepareToSuspend( > SetForScope<bool> suspensionScope(m_isSuspending, true); > m_processIsSuspended = true; > >+#if PLATFORM(COCOA) >+ if (m_processType == ProcessType::PrewarmedWebContent) { >+ if (shouldAcknowledgeWhenReadyToSuspend == ShouldAcknowledgeWhenReadyToSuspend::Yes) { >+ RELEASE_LOG(ProcessSuspension, "%p - WebProcess::actualPrepareToSuspend() Sending ProcessReadyToSuspend IPC message", this); >+ parentProcessConnection()->send(Messages::WebProcessProxy::ProcessReadyToSuspend(), 0); >+ } >+ return; >+ } >+#endif >+ > #if ENABLE(VIDEO) > suspendAllMediaBuffering(); > if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists()) >@@ -1527,6 +1537,11 @@ void WebProcess::cancelPrepareToSuspend( > > m_processIsSuspended = false; > >+#if PLATFORM(COCOA) >+ if (m_processType == ProcessType::PrewarmedWebContent) >+ return; >+#endif >+ > unfreezeAllLayerTrees(); > > #if PLATFORM(IOS_FAMILY) >@@ -1603,6 +1618,11 @@ void WebProcess::processDidResume() > > m_processIsSuspended = false; > >+#if PLATFORM(COCOA) >+ if (m_processType == ProcessType::PrewarmedWebContent) >+ return; >+#endif >+ > cancelMarkAllLayersVolatile(); > unfreezeAllLayerTrees(); >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199195
:
372848
|
372853
|
373132
|
373134
|
373186
|
373234