Attachment 373133 Details for Bug 199326 – Patch

[patch] Patch

bug-199326-20190628110727.patch (text/plain), 4.82 KB, created by Priyanka on 2019-06-28 11:07:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Priyanka

Created: 2019-06-28 11:07:29 PDT

Size: 4.82 KB

patch

obsolete

>Subversion Revision: 246896
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dcb3e109101ae7c82471a0356db0837bcc825f13..5843caf6e9cb55a0be3b65ea56574eabdd517cd2 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-06-28  Priyanka Agarwal  <pagarwal999@apple.com>
>+
>+        Allow Clients to Add Fields to the AutoFillContext Dictionary
>+        https://bugs.webkit.org/show_bug.cgi?id=199326
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/_WKInputDelegate.h:
>+        Added function declaration for function which returns additional dictionary for autofillcontext
>+
>+        * UIProcess/ios/WKContentViewInteraction.h:
>+        Created dictionary for additional autofillcontext
>+ 
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
>+        Populating additional dictionary for autofillcontext
>+
>+        (-[WKContentView _autofillContext]):
>+        Adding new dictionary to the returned autofillcontext
>+
> 2019-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebSockets: avoid data copies when queuing tasks in WebSocketChannel
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h b/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h
>index 1665279d366ebb20fdcb56d2861126f4a317d14b..3f4bd9b8f203e7512b8d78e4f89fd2622ee8f281 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/_WKInputDelegate.h
>@@ -55,6 +55,8 @@ typedef NS_ENUM(NSInteger, _WKFocusStartsInputSessionPolicy) {
> - (void)_webView:(WKWebView *)webView willStartInputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
> - (BOOL)_webView:(WKWebView *)webView focusRequiresStrongPasswordAssistance:(id <_WKFocusedElementInfo>)info WK_API_AVAILABLE(ios(12.0));
> 
>+- (NSDictionary *)_webViewAdditionalContextForStrongPasswordAssistance:(WKWebView *)webView;
>+
> - (BOOL)_webView:(WKWebView *)webView shouldRevealFocusOverlayForInputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
> - (CGFloat)_webView:(WKWebView *)webView focusedElementContextViewHeightForFittingSize:(CGSize)fittingSize inputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
> - (UIView *)_webView:(WKWebView *)webView focusedElementContextViewForInputSession:(id <_WKFormInputSession>)inputSession WK_API_AVAILABLE(ios(12.0));
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>index 90f784db9797e668853e8d7e28c99c9db1a1f565..d608a65991e3a05ea2b9471d24051794316c81f6 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>@@ -349,6 +349,8 @@ struct WKAutoCorrectionData {
>     CompletionHandler<void(WebCore::DOMPasteAccessResponse)> _domPasteRequestHandler;
>     BlockPtr<void(UIWKAutocorrectionContext *)> _pendingAutocorrectionContextHandler;
> 
>+    NSDictionary *_sfAutoFillAdditionalContext;
>+
> #if ENABLE(DATA_INTERACTION)
>     WebKit::DragDropInteractionState _dragDropInteractionState;
>     RetainPtr<UIDragInteraction> _dragInteraction;
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 33938e495dfeb5b35d950d41cae488b982b2490f..43a944e53e4dcf3e2e775bd1468b5ef2c4db0990 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -5212,6 +5212,11 @@ - (void)_elementDidFocus:(const WebKit::FocusedElementInformation&)information u
>     if ([inputDelegate respondsToSelector:@selector(_webView:focusRequiresStrongPasswordAssistance:)])
>         _focusRequiresStrongPasswordAssistance = [inputDelegate _webView:_webView focusRequiresStrongPasswordAssistance:focusedElementInfo.get()];
> 
>+    if ([inputDelegate respondsToSelector:@selector(_webViewAdditionalContextForStrongPasswordAssistance:)])
>+        _sfAutoFillAdditionalContext = [inputDelegate _webViewAdditionalContextForStrongPasswordAssistance:_webView];
>+    else
>+        _sfAutoFillAdditionalContext = @{ };
>+
>     bool delegateImplementsWillStartInputSession = [inputDelegate respondsToSelector:@selector(_webView:willStartInputSession:)];
>     bool delegateImplementsDidStartInputSession = [inputDelegate respondsToSelector:@selector(_webView:didStartInputSession:)];
> 
>@@ -6636,7 +6641,7 @@ - (NSDictionary *)_autofillContext
>         return nil;
> 
>     if (provideStrongPasswordAssistance)
>-        return @{ @"_automaticPasswordKeyboard" : @YES };
>+        return @{ @"_automaticPasswordKeyboard" : @YES, @"sfAutoFillAdditionalContext": _sfAutoFillAdditionalContext};
> 
>     NSURL *platformURL = _focusedElementInformation.representingPageURL;
>     if (platformURL)

Actions: View | Formatted Diff | Diff

Attachments on bug 199326: 373133 | 373157 | 373158 | 373284 | 374748 | 374761 | 374763 | 374800 | 374804 | 374812 | 374833