Attachment 373114 Details for Bug 199314 – Patch

[patch] Patch

bug-199314-20190628161718.patch (text/plain), 10.07 KB, created by Rob Buis on 2019-06-28 07:17:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2019-06-28 07:17:19 PDT

Size: 10.07 KB

patch

obsolete

>Subversion Revision: 246921
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 039dd1f6a0151c9a91959468da1349f4e53d1109..99d084d0be655e9a908ea4874751068b05a6ffff 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-06-28  Rob Buis  <rbuis@igalia.com>
>+
>+        Re-enable some prefetch tests
>+        https://bugs.webkit.org/show_bug.cgi?id=199314
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unskip old prefetch tests since they pass on WK2 but keep skipping them for WK1.
>+        Remove link-rel-prefetch-and-subresource.html since it tests rel=subresource which
>+        is not supported by any browser engine.
>+
>+        * TestExpectations:
>+        * http/tests/misc/link-rel-prefetch-and-subresource-expected.txt: Removed.
>+        * http/tests/misc/link-rel-prefetch-and-subresource.html: Removed.
>+        * platform/mac/TestExpectations:
>+        * platform/win/TestExpectations:
>+
> 2019-06-27  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Fix the test added in r246868 on iOS debug simulator.
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index e1e8f7ca84352db08627ad74aa24eeb188199051..6d4e5dd6db593864d0536d8f1621af649dda3072 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-28  Rob Buis  <rbuis@igalia.com>
>+
>+        Re-enable some prefetch tests
>+        https://bugs.webkit.org/show_bug.cgi?id=199314
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update expectation.
>+
>+        * web-platform-tests/fetch/api/request/destination/fetch-destination-prefetch.https-expected.txt:
>+
> 2019-06-26  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 69382a915418b6e1b11e1280c73972db79708521..0d387ddfd2e57f8b394b08109398c24409c135af 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -605,7 +605,6 @@ imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-
> imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination.https.html [ Skip ]
> imported/w3c/web-platform-tests/fetch/range/sw.https.window.html [ Skip ]
> imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html [ Skip ]
>-imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-prefetch.https.html [ Skip ]
> imported/w3c/web-platform-tests/fetch/content-type/response.window.html [ Skip ]
> 
> # Not supported
>@@ -2329,17 +2328,8 @@ webkit.org/b/99945 fast/css3-text/css3-text-justify [ Skip ]
> webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ Skip ]
> webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle [ Skip ]
> 
>-# Link prefetch is disabled by default (needs ENABLE_LINK_PREFETCH)
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
>+# Link prefetch
> webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-beforeload.html [ Skip ]
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ]
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ]
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-too-many-clients.html [ Skip ]
>-webkit.org/b/3652 fast/dom/HTMLLinkElement/subresource.html [ Skip ]
>-webkit.org/b/3652 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
>-webkit.org/b/3652 http/tests/misc/prefetch-purpose.html [ Skip ]
> 
> # First-party-only cookie policy only supported on Cocoa platforms.
> http/tests/cookies/only-accept-first-party-cookies.html [ Skip ]
>diff --git a/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource-expected.txt b/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource-expected.txt
>deleted file mode 100644
>index 5284788216daab315c9c85af694a33c83a629593..0000000000000000000000000000000000000000
>--- a/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource-expected.txt
>+++ /dev/null
>@@ -1,8 +0,0 @@
>-Resource requests:
>-
>-
>-1st.jpg
>-2nd.jpg
>-3rd.jpg
>-4th.jpg
>-5th.jpg
>diff --git a/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource.html b/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource.html
>deleted file mode 100644
>index b724bbe5bc208967634b50a6a69f84ef08448ed1..0000000000000000000000000000000000000000
>--- a/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource.html
>+++ /dev/null
>@@ -1,73 +0,0 @@
>-<html>
>-<head>
>-  <script>
>-function CallCommand(cmd)
>-{
>- try {
>-     var req = new XMLHttpRequest;
>-     req.open("GET", "/resources/network-simulator.php?test=misc-link-rel-prefetch-and-subresource&command=" + cmd, false);
>-     req.send(null);
>-     return req.responseText;
>- } catch (ex) {
>-     return "";
>- }
>-}
>-
>-function startTest()
>-{
>-    if (window.testRunner) {
>-        testRunner.dumpAsText();
>-        testRunner.waitUntilDone();
>-    }
>-}
>-
>-function endTest()
>-{
>-    getResourceLog();
>-    CallCommand("clear-resource-request-log");
>-
>-    if (window.testRunner)
>-        testRunner.notifyDone();
>-}
>-
>-function getResourceLog()
>-{
>-    var log = CallCommand("get-resource-request-log");
>-    var logLines = log.split('\n');
>-    logLines.sort();
>-    document.getElementById('result').innerText = logLines.join('\n');
>-}
>-
>-CallCommand("start-resource-request-log");
>-window.addEventListener('load', startTest, false);
>-  </script>
>-
>-  
>-
>-  <script>
>-  var linkLoadCount = 5;
>-
>-  function decrementLinkLoadCount()
>-  {
>-      linkLoadCount--;
>-      if (linkLoadCount == 0) {
>-          endTest();
>-      }
>-  }
>-  </script>
>-  <link rel=prefetch onload="decrementLinkLoadCount()" href="/resources/network-simulator.php?test=misc-link-rel-prefetch-and-subresource&command=log-resource-request&path=1st.jpg">
>-  <link rel=subresource onload="decrementLinkLoadCount()" href="/resources/network-simulator.php?test=misc-link-rel-prefetch-and-subresource&command=log-resource-request&path=2nd.jpg">
>-  <link rel=prefetch onload="decrementLinkLoadCount()" href="/resources/network-simulator.php?test=misc-link-rel-prefetch-and-subresource&command=log-resource-request&path=3rd.jpg">
>-  <link rel=prefetch onload="decrementLinkLoadCount()" href="/resources/network-simulator.php?test=misc-link-rel-prefetch-and-subresource&command=log-resource-request&path=4th.jpg">
>-  <link rel=subresource onload="decrementLinkLoadCount()" href="/resources/network-simulator.php?test=misc-link-rel-prefetch-and-subresource&command=log-resource-request&path=5th.jpg">
>-</head>
>-<body>
>-
>-  <div class="box bordered"></div>
>-
>-  <h2>Resource requests:</h2>
>-  <pre id="result">Request log goes here in DRT</pre>
>-</body>
>-</html>
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-prefetch.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-prefetch.https-expected.txt
>index 601f5651d716e85eb2e139d7bb7500fb53d5b70e..dcbd910bc8c6e9f974bd83915c009fbd39d94965 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-prefetch.https-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-prefetch.https-expected.txt
>@@ -1,6 +1,4 @@
> 
>-Harness Error (TIMEOUT), message = null
>-
> PASS Initialize global state 
>-TIMEOUT HTMLLinkElement with rel=prefetch fetches with an empty string Request.destination Test timed out
>+PASS HTMLLinkElement with rel=prefetch fetches with an empty string Request.destination 
> 
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 1b9ae7dc73ea7206ed16faf809c1364dffe4dd3f..71a2d1727c0bdb9e07f8a36e40f6f02c5c978e17 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1935,3 +1935,12 @@ webkit.org/b/199013 [ Debug Mojave+ ] imported/w3c/web-platform-tests/websockets
> webkit.org/b/190882 [ Mojave+ ] animations/change-one-anim.html [ Pass Failure ]
> 
> webkit.org/b/195635 scrollingcoordinator/mac/multiple-fixed.html [ Pass Timeout ]
>+
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/subresource.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
>+webkit.org/b/3652 http/tests/misc/prefetch-purpose.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
>+
>diff --git a/LayoutTests/platform/win/TestExpectations b/LayoutTests/platform/win/TestExpectations
>index 525a242d106e2ed1ffc5becf5a1e0487a3df735f..b06e31851f3f2394431ccd5650153f97f2f779b2 100644
>--- a/LayoutTests/platform/win/TestExpectations
>+++ b/LayoutTests/platform/win/TestExpectations
>@@ -4422,3 +4422,12 @@ webkit.org/b/197371 http/wpt/prefetch/link-prefetch-main-resource-redirect.html
> webkit.org/b/198112 http/tests/security/showModalDialog-sync-cross-origin-page-load2.html [ Skip ]
> 
> webkit.org/b/198679 fast/events/fire-mousedown-while-pressing-mouse-button.html [ Failure ]
>+
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/subresource.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
>+webkit.org/b/3652 http/tests/misc/prefetch-purpose.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
>+webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
>+

Actions: View | Formatted Diff | Diff

Attachments on bug 199314: 373094 | 373097 | 373099 | 373100 | 373105 | 373114