Attachment 373102 Details for Bug 199313 – Patch

[patch] Patch

bug-199313-20190628192942.patch (text/plain), 2.54 KB, created by Fujii Hironori on 2019-06-28 03:29:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-06-28 03:29:43 PDT

Size: 2.54 KB

patch

obsolete

>Subversion Revision: 246920
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 039dd1f6a0151c9a91959468da1349f4e53d1109..fd401afe10e55b4a2fd5e1a0331c587cfb211bad 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-28  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        LayoutTests svg/clip-path/clip-hidpi.svg isn't working as expected due to a syntax error
>+        https://bugs.webkit.org/show_bug.cgi?id=199313
>+
>+        Reviewed by Carlos Garcia Campos.
>+
>+        * svg/clip-path/clip-hidpi.svg: Fix the syntax error by replacing '->' with '=>'.
>+        Call testRunner.waitUntilDone() before testRunner.notifyDone().
>+        * svg/clip-path/clip-hidpi-expected.svg: Call testRunner.setBackingScaleFactor().
>+
> 2019-06-27  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Fix the test added in r246868 on iOS debug simulator.
>diff --git a/LayoutTests/svg/clip-path/clip-hidpi-expected.svg b/LayoutTests/svg/clip-path/clip-hidpi-expected.svg
>index d9eb369e94e4a586b724dedcce6cf8d71b26d88c..2458f623b60fa833bab5e2254658c34e4d6de1e6 100644
>--- a/LayoutTests/svg/clip-path/clip-hidpi-expected.svg
>+++ b/LayoutTests/svg/clip-path/clip-hidpi-expected.svg
>@@ -1,18 +1,15 @@
> <svg xmlns="http://www.w3.org/2000/svg">
>-
>-<defs>
>-<clipPath id="clip">
>-    <rect width="200" height="50"/>
>-    <rect width="200" height="50"/>
>-</clipPath>
>-</defs>
>-<foreignObject width="200" height="100" clip-path="url(#clip)" opacity=".5">
>+<foreignObject width="200" height="100" opacity=".5">
>     <html xmlns="http://www.w3.org/1999/xhtml">
>     <body>
>         <div style="background: green; height: 50px;"></div>
>-        <div style="background: red; height: 50px;"></div>
>     </body>
>     </html>
> </foreignObject>
>+<script>
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    testRunner.setBackingScaleFactor(2, () => { testRunner.notifyDone() });
>+}
>+</script>
> </svg>
>-
>diff --git a/LayoutTests/svg/clip-path/clip-hidpi.svg b/LayoutTests/svg/clip-path/clip-hidpi.svg
>index 4b525153f82cb5f028203e58e803101ad37011a5..be19296aa121691d6220e3affea849c875cefe57 100644
>--- a/LayoutTests/svg/clip-path/clip-hidpi.svg
>+++ b/LayoutTests/svg/clip-path/clip-hidpi.svg
>@@ -15,8 +15,10 @@
>     </html>
> </foreignObject>
> <script>
>-  testRunner.setBackingScaleFactor(2, () -> { testRunner.notifyDone() });
>-  testRunner.waitUntilDone();
>+if (window.testRunner) {
>+    testRunner.waitUntilDone();
>+    testRunner.setBackingScaleFactor(2, () => { testRunner.notifyDone() });
>+}
> </script>
> </svg>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199313: 373092 | 373096 | 373098 | 373102