Attachment 373089 Details for Bug 199312 – Patch

[patch] Patch

bug-199312-20190628150933.patch (text/plain), 2.40 KB, created by Fujii Hironori on 2019-06-27 23:09:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-06-27 23:09:34 PDT

Size: 2.40 KB

patch

obsolete

>Subversion Revision: 246921
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8f6a48f6e5ad7f1229c5cce9928739da64bda4bf..88dde19596a708adfbc4d6e1ba3d951b9bed01a9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-27  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win] unresolved external symbol "JSC::JSObject::didBecomePrototype(void)" referenced in function "JSC::Structure::create(...)"
>+        https://bugs.webkit.org/show_bug.cgi?id=199312
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WinCairo port, clang-cl Release builds reported a following linkage error:
>+
>+        > WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol "public: void __cdecl JSC::JSObject::didBecomePrototype(void)" (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function "public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)
>+
>+        No new tests because there is no behavior change.
>+
>+        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Include <JavaScriptCore/JSCInlines.h>,
>+        and do not include headers which is included by it.
>+
> 2019-06-27  Zalan Bujtas  <zalan@apple.com>
> 
>         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
>diff --git a/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp b/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
>index d1b047cef65ac3d9f92dbf3fdbc1c645082220ca..0899a9ab7e96c857955b26a7b0ab0bc802c29590 100644
>--- a/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
>+++ b/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
>@@ -49,11 +49,8 @@
> #include "SQLiteTransaction.h"
> #include "ThreadSafeDataBuffer.h"
> #include <JavaScriptCore/AuxiliaryBarrierInlines.h>
>-#include <JavaScriptCore/HeapInlines.h>
>-#include <JavaScriptCore/JSCJSValueInlines.h>
>-#include <JavaScriptCore/JSGlobalObject.h>
>+#include <JavaScriptCore/JSCInlines.h>
> #include <JavaScriptCore/StrongInlines.h>
>-#include <JavaScriptCore/StructureInlines.h>
> #include <wtf/FileSystem.h>
> #include <wtf/NeverDestroyed.h>
> #include <wtf/text/StringConcatenateNumbers.h>

Actions: View | Formatted Diff | Diff

Attachments on bug 199312: 373089