Attachment 373048 Details for Bug 199280 – Patch

[patch] Patch

bug-199280-20190627132319.patch (text/plain), 3.24 KB, created by Russell Epstein on 2019-06-27 13:23:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Russell Epstein

Created: 2019-06-27 13:23:19 PDT

Size: 3.24 KB

patch

obsolete

>Subversion Revision: 246898
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 97344c3fc2e3cf6f94d52825c999b7a438a60f5e..76336815e23765e00e0c2d7f54cf87802866779d 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-27  Russell Epstein  <russell_e@apple.com>
>+
>+        Layout Test fast/parser/parser-yield-timing.html was flaky due to strict tolerance, increased tolerance.
>+        https://bugs.webkit.org/show_bug.cgi?id=199280
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/parser/parser-yield-timing-expected.txt:
>+        * fast/parser/parser-yield-timing.html:
>+        * platform/mac-wk1/TestExpectations:
>+
> 2019-06-27  Russell Epstein  <russell_e@apple.com>
> 
>         Layout Test fast/parser/parser-yield-timing.html is flaky.
>diff --git a/LayoutTests/fast/parser/parser-yield-timing-expected.txt b/LayoutTests/fast/parser/parser-yield-timing-expected.txt
>index 948da42452ba3d5e5f04e49bee5e8233d10623d7..75dccbe2b26d8bfe0aa2168e8a0dba658f97c399 100644
>--- a/LayoutTests/fast/parser/parser-yield-timing-expected.txt
>+++ b/LayoutTests/fast/parser/parser-yield-timing-expected.txt
>@@ -3,9 +3,9 @@ Runs 3 separate 1 second <script> blocks with a setTimeout schedule before each.
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
>-PASS new Date().getTime() - startTime is within 300 of 1000
>-PASS new Date().getTime() - startTime is within 300 of 2000
>-PASS new Date().getTime() - startTime is within 300 of 3000
>+PASS new Date().getTime() - startTime is within 400 of 1000
>+PASS new Date().getTime() - startTime is within 400 of 2000
>+PASS new Date().getTime() - startTime is within 400 of 3000
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/fast/parser/parser-yield-timing.html b/LayoutTests/fast/parser/parser-yield-timing.html
>index 5eb30aa84477cc34e10e3cdfb5f3ca0b14525e14..8e40ad21c280a381679e7d84e078ee421daee03d 100644
>--- a/LayoutTests/fast/parser/parser-yield-timing.html
>+++ b/LayoutTests/fast/parser/parser-yield-timing.html
>@@ -8,7 +8,7 @@
>       description("Runs 3 separate 1 second &lt;script&gt; blocks with a setTimeout schedule before each. The execution time of the setTimeout is when the HTML yielded to the event loop. The yields also represent painting opportunities. We want the parser to yield every 0.5 seconds once it has seen a script.");
> 
>       var startTime = new Date().getTime();
>-      var tolerance = 300; // 300 ms
>+      var tolerance = 400; // 400 ms
> 
>       function expectElapsedTime(expectedTime) {
>         shouldBeCloseTo("new Date().getTime() - startTime", expectedTime, tolerance);
>diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations
>index 758f9044e5e680b5349ee619d45ca8b464a042ec..aa11d9bc2965cd7d8465e180fa6762ccb013e0ef 100644
>--- a/LayoutTests/platform/mac-wk1/TestExpectations
>+++ b/LayoutTests/platform/mac-wk1/TestExpectations
>@@ -746,5 +746,3 @@ webkit.org/b/198676 imported/w3c/web-platform-tests/content-security-policy/repo
> 
> webkit.org/b/199242 [ Debug ] http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash.html [ Pass Failure ]
> 
>-webkit.org/b/199280 [ Debug Mojave ] fast/parser/parser-yield-timing.html [ Pass Failure ]
>-

Actions: View | Formatted Diff | Diff

Attachments on bug 199280: 373040 | 373048