Attachment 373047 Details for Bug 199274 – Patch

[patch] Patch

bug-199274-20190627131754.patch (text/plain), 1.60 KB, created by Simon Fraser (smfr) on 2019-06-27 13:17:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-06-27 13:17:55 PDT

Size: 1.60 KB

patch

obsolete

>Subversion Revision: 246894
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f93c3ea6b030b32dbb13aaf14826353eccf43e0b..bd4302c033417c6d2727ebce98ae79cb070fa1be 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-27  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r246869): ASSERTION FAILED: !renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint())
>+        https://bugs.webkit.org/show_bug.cgi?id=199274
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When layer backing sharing changes, we need to clear cached repaint rects, since they
>+        painting root changes.
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::setBackingProviderLayer):
>+
> 2019-06-27  Beth Dakin  <bdakin@apple.com>
> 
>         Upstream use of MACCATALYST
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index ca7290a02d3b7033d06c6394fa909f80f3efd016..79b1c872f24db5eb66b0cc56f79f8c431169b4f7 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -1788,8 +1788,10 @@ void RenderLayer::setBackingProviderLayer(RenderLayer* backingProvider)
>     if (backingProvider == m_backingProviderLayer)
>         return;
> 
>-    if (!renderer().renderTreeBeingDestroyed())
>+    if (!renderer().renderTreeBeingDestroyed()) {
>+        clearRepaintRects();
>         clearClipRectsIncludingDescendants();
>+    }
> 
>     m_backingProviderLayer = makeWeakPtr(backingProvider);
> }

Flags:

zalan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 199274: 373047