Attachment 373018 Details for Bug 199266 – Patch

[patch] Patch

bug-199266-20190627135255.patch (text/plain), 1.22 KB, created by Paulo Matos on 2019-06-27 04:53:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo Matos

Created: 2019-06-27 04:53:05 PDT

Size: 1.22 KB

patch

obsolete

>Subversion Revision: 246674
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 983eb8fab31929fb7b6cdd3dc7f6babd9f793fd1..54e17754a940bf67c2f467ce8e8470516281a0f9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-27  Paulo Matos  <pmatos@igalia.com>
>+
>+        JSC binary not being copied into payload for benchmarking
>+        https://bugs.webkit.org/show_bug.cgi?id=199266
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/run-jsc-benchmarks: Copy jsc into benchmark temp
>+        so that's it is properly added into payload.
>+
> 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
> 
>         test-webkitpy is broken on macOS Catalina
>diff --git a/Tools/Scripts/run-jsc-benchmarks b/Tools/Scripts/run-jsc-benchmarks
>index 2ccfe923d30e50b7b209a2480432e672f6cb3ed0..e3708cd850272ac372134105abc0a9fa8ee4d840 100755
>--- a/Tools/Scripts/run-jsc-benchmarks
>+++ b/Tools/Scripts/run-jsc-benchmarks
>@@ -1419,6 +1419,9 @@ class VM
>       raise unless system(cmd)
>     }
>     @path = "#{basename}/#{@relativeBinPath}"
>+    cmd = "cp #{Shellwords.shellescape(origPath)} #{Shellwords.shellescape(filename.to_s)}"
>+    $stderr.puts ">> #{cmd}" if $verbosity>=2
>+    raise unless system(cmd)
>     @libPath = [basename]
>   end
>

Flags:

pmatos: review?
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 199266: 373018 | 373024