Attachment 373015 Details for Bug 199264 – Patch

[patch] Patch

Bug199264.patch (text/plain), 3.04 KB, created by Fujii Hironori on 2019-06-27 03:22:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-06-27 03:22:08 PDT

Size: 3.04 KB

patch

obsolete

>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 59481f6ca7e..757d08c9379 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-27  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [JSC] OpcodeID should be the same size of uintptr_t in 64bit
>+        https://bugs.webkit.org/show_bug.cgi?id=199264
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * assembler/MacroAssemblerCodeRef.h:
>+        * bytecode/Opcode.h:
>+        * parser/Nodes.h:
>+        * profiler/ProfilerBytecode.h:
>+        Changed the base class of enum OpcodeID from unsigned to uintptr_t.
>+
> 2019-06-25  Keith Miller  <keith_miller@apple.com>
> 
>         Structure::create should call didBecomePrototype()
>diff --git a/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h b/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h
>index 54658dd1dab..bf04f27f6a4 100644
>--- a/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h
>+++ b/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h
>@@ -56,7 +56,7 @@ namespace JSC {
> 
> template<PtrTag> class MacroAssemblerCodePtr;
> 
>-enum OpcodeID : unsigned;
>+enum OpcodeID : uintptr_t;
> 
> // FunctionPtr:
> //
>diff --git a/Source/JavaScriptCore/bytecode/Opcode.h b/Source/JavaScriptCore/bytecode/Opcode.h
>index c921dd813c6..6d0d2d0aea6 100644
>--- a/Source/JavaScriptCore/bytecode/Opcode.h
>+++ b/Source/JavaScriptCore/bytecode/Opcode.h
>@@ -61,17 +61,17 @@ const int numOpcodeIDs = NUMBER_OF_BYTECODE_IDS + NUMBER_OF_BYTECODE_HELPER_IDS;
> #endif
> 
> #define OPCODE_ID_ENUM(opcode, length) opcode,
>-    enum OpcodeID : unsigned { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) };
>+    enum OpcodeID : uintptr_t { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) };
> #undef OPCODE_ID_ENUM
> 
> #if ENABLE(C_LOOP) && !HAVE(COMPUTED_GOTO)
> 
> #define OPCODE_ID_ENUM(opcode, length) opcode##_wide16 = numOpcodeIDs + opcode,
>-    enum OpcodeIDWide16 : unsigned { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) };
>+    enum OpcodeIDWide16 : uintptr_t { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) };
> #undef OPCODE_ID_ENUM
> 
> #define OPCODE_ID_ENUM(opcode, length) opcode##_wide32 = numOpcodeIDs * 2 + opcode,
>-    enum OpcodeIDWide32 : unsigned { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) };
>+    enum OpcodeIDWide32 : uintptr_t { FOR_EACH_OPCODE_ID(OPCODE_ID_ENUM) };
> #undef OPCODE_ID_ENUM
> #endif
> 
>diff --git a/Source/JavaScriptCore/parser/Nodes.h b/Source/JavaScriptCore/parser/Nodes.h
>index 60ba5eea2d5..c2fa6190b5e 100644
>--- a/Source/JavaScriptCore/parser/Nodes.h
>+++ b/Source/JavaScriptCore/parser/Nodes.h
>@@ -39,7 +39,7 @@
> 
> namespace JSC {
> 
>-    enum OpcodeID : unsigned;
>+    enum OpcodeID : uintptr_t;
> 
>     class ArgumentListNode;
>     class BytecodeGenerator;
>diff --git a/Source/JavaScriptCore/profiler/ProfilerBytecode.h b/Source/JavaScriptCore/profiler/ProfilerBytecode.h
>index 72c66c5c34e..5701810968e 100644
>--- a/Source/JavaScriptCore/profiler/ProfilerBytecode.h
>+++ b/Source/JavaScriptCore/profiler/ProfilerBytecode.h
>@@ -30,7 +30,7 @@
> 
> namespace JSC {
> 
>-enum OpcodeID : unsigned;
>+enum OpcodeID : uintptr_t;
> 
> namespace Profiler {
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199264: 373015 | 375281 | 375283 | 435843