Attachment 372975 Details for Bug 199250 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

update-1.patch (text/plain), 4.24 KB, created by Joseph Pecoraro on 2019-06-26 17:38:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-06-26 17:38:35 PDT

Size: 4.24 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index cf061be3b17..3f49dc7767b 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-26  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Update legacy backend commands after enum name change
>+        https://bugs.webkit.org/show_bug.cgi?id=199250
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
>+        * UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:
>+        * UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js:
>+
> 2019-06-26  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION: Elements: the forced pseudo-class indicator isn't visible when hovering
>diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js
>index 0e62f4b3604..c0903632493 100644
>--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js
>+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js
>@@ -67,7 +67,7 @@ InspectorBackend.activateDomain("CSS", ["web"]);
> 
> // Canvas.
> InspectorBackend.registerCanvasDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Canvas");
>-InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", Webgpu: "webgpu"});
>+InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", WebGPU: "webgpu"});
> InspectorBackend.registerEnum("Canvas.ShaderType", {Fragment: "fragment", Vertex: "vertex"});
> InspectorBackend.registerEvent("Canvas.canvasAdded", ["canvas"]);
> InspectorBackend.registerEvent("Canvas.canvasRemoved", ["canvasId"]);
>diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js
>index ee6925a4abb..1553681baf9 100644
>--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js
>+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js
>@@ -67,7 +67,7 @@ InspectorBackend.activateDomain("CSS", ["web"]);
> 
> // Canvas.
> InspectorBackend.registerCanvasDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Canvas");
>-InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", Webgpu: "webgpu"});
>+InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", WebGPU: "webgpu"});
> InspectorBackend.registerEnum("Canvas.ShaderType", {Fragment: "fragment", Vertex: "vertex"});
> InspectorBackend.registerEvent("Canvas.canvasAdded", ["canvas"]);
> InspectorBackend.registerEvent("Canvas.canvasRemoved", ["canvasId"]);
>diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js
>index 8ac5c10c6af..8e680978378 100644
>--- a/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js
>+++ b/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js
>@@ -67,7 +67,7 @@ InspectorBackend.activateDomain("CSS", ["web"]);
> 
> // Canvas.
> InspectorBackend.registerCanvasDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Canvas");
>-InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", WebMetal: "webmetal"});
>+InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", Webmetal: "webmetal"});
> InspectorBackend.registerEnum("Canvas.ShaderType", {Fragment: "fragment", Vertex: "vertex"});
> InspectorBackend.registerEvent("Canvas.canvasAdded", ["canvas"]);
> InspectorBackend.registerEvent("Canvas.canvasRemoved", ["canvasId"]);

Actions: View | Formatted Diff | Diff

Attachments on bug 199250: 372975