Attachment 372969 Details for Bug 199244 – Patch for landing

[patch] Patch for landing

bug-199244-20190626165820.patch (text/plain), 2.59 KB, created by Ross Kirsling on 2019-06-26 16:58:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2019-06-26 16:58:22 PDT

Size: 2.59 KB

patch

obsolete

>Subversion Revision: 246849
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 031287653b4ec1ed56569fe77d25ce10883be69b..b536df347f13b8138b8c46c75b9dc1121e1eba0a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        [Win] MiniBrowser should make better font choices
>+        https://bugs.webkit.org/show_bug.cgi?id=199244
>+
>+        Reviewed by Brent Fulgham.
>+
>+        * MiniBrowser/win/MainWindow.cpp:
>+        (MainWindow::updateDeviceScaleFactor):
>+        * MiniBrowser/win/MiniBrowserLib.rc:
>+
> 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [Win][MiniBrowser] Remove obsolete code after r246814.
>diff --git a/Tools/MiniBrowser/win/MainWindow.cpp b/Tools/MiniBrowser/win/MainWindow.cpp
>index fbd6e32dff9855f6eae4f6e8e3b82797a8776939..ac71f666e883c6968d398b5892003b15eca0347c 100644
>--- a/Tools/MiniBrowser/win/MainWindow.cpp
>+++ b/Tools/MiniBrowser/win/MainWindow.cpp
>@@ -452,6 +452,6 @@ void MainWindow::updateDeviceScaleFactor()
>     auto scaleFactor = WebCore::deviceScaleFactorForWindow(m_hMainWnd);
>     int fontHeight = scaleFactor * urlBarHeight * 3 / 4;
>     m_hURLBarFont = ::CreateFont(fontHeight, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET,
>-        OUT_TT_ONLY_PRECIS, CLIP_DEFAULT_PRECIS, ANTIALIASED_QUALITY, FF_DONTCARE, L"Times New Roman");
>+        OUT_TT_ONLY_PRECIS, CLIP_DEFAULT_PRECIS, CLEARTYPE_QUALITY, FF_DONTCARE, L"Tahoma");
>     ::SendMessage(m_hURLBarWnd, static_cast<UINT>(WM_SETFONT), reinterpret_cast<WPARAM>(m_hURLBarFont), TRUE);
> }
>diff --git a/Tools/MiniBrowser/win/MiniBrowserLib.rc b/Tools/MiniBrowser/win/MiniBrowserLib.rc
>index f88771a61f941ac0f214492690affddcb0ca4211..c7930fed6d624dca746bf53e99be573316773398 100755
>--- a/Tools/MiniBrowser/win/MiniBrowserLib.rc
>+++ b/Tools/MiniBrowser/win/MiniBrowserLib.rc
>@@ -138,15 +138,15 @@ END
> // Dialog
> //
> 
>-IDD_ABOUTBOX DIALOGEX 22, 17, 230, 75
>+IDD_ABOUTBOX DIALOGEX 22, 17, 230, 41
> STYLE DS_SETFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU
> CAPTION "About"
>-FONT 8, "System", 0, 0, 0x0
>+FONT 8, "MS Shell Dlg", 0, 0, 0x0
> BEGIN
>     ICON            IDI_MINIBROWSER,IDC_MYICON,14,9,20,20
>-    LTEXT           "MiniBrowser Version 1.0",IDC_STATIC,49,10,119,8,SS_NOPREFIX
>-    LTEXT           "Copyright (C) 2015",IDC_STATIC,49,20,119,8
>-    DEFPUSHBUTTON   "OK",IDOK,195,6,30,11,WS_GROUP
>+    LTEXT           "MiniBrowser Version 1.1",IDC_STATIC,49,10,119,8
>+    LTEXT           "Copyright (C) 2015-2019",IDC_STATIC,49,20,119,8
>+    DEFPUSHBUTTON   "OK",IDOK,186,10,30,11,WS_GROUP
> END
> 
> IDD_CACHES DIALOGEX 0, 0, 401, 456

Actions: View | Formatted Diff | Diff

Attachments on bug 199244: 372966 | 372967 | 372969