Attachment 372963 Details for Bug 199241 – Patch

[patch] Patch

bug-199241-20190626161625.patch (text/plain), 1.65 KB, created by Daniel Bates on 2019-06-26 16:16:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-06-26 16:16:26 PDT

Size: 1.65 KB

patch

obsolete

>Subversion Revision: 246682
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a1f3c09cc875ef54be094548d5be8e5b46406df2..0d0dd922c77d4b5db4c9b71ee8fb327e5f3995b4 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-26  Daniel Bates  <dabates@apple.com>
>+
>+        Remove all animations before dumping results
>+        https://bugs.webkit.org/show_bug.cgi?id=199241
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On iOS various things like selection animate. We have many historical tests that
>+        were written for Mac and expect Mac's lack of animations that we run on iOS are
>+        are flaky. Let's try to remove all animations before dumping results and see if
>+        this makes tests on iOS less flaky. A future enhancement to this is to expose a
>+        uiController API for a test to remove animations at any time during the run.
>+
>+        * WebKitTestRunner/ios/TestControllerIOS.mm:
>+        (WTR::TestController::notifyDone):
>+
> 2019-06-17  Daniel Bates  <dabates@apple.com>
> 
>         [lldb-webkit] Show whether frame is focused in Frame and Document summaries
>diff --git a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>index 73706313ae86c3975c423d9667b7e7f38e2dee18..dd283c1dbd2d743a75dd12b747c8ffa6681dc50b 100644
>--- a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>+++ b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>@@ -82,6 +82,7 @@ static void handleMenuDidHideNotification(CFNotificationCenterRef, void*, CFStri
> 
> void TestController::notifyDone()
> {
>+    [[mainWebView()->platformView() scrollView] _removeAllAnimations:YES];
> }
> 
> void TestController::platformInitialize()

Actions: View | Formatted Diff | Diff

Attachments on bug 199241: 372963 | 372983 | 377062 | 377063