Attachment 372955 Details for Bug 198999 – Patch

[patch] Patch

bug-198999-20190627000846.patch (text/plain), 2.12 KB, created by Antoine Quint on 2019-06-26 15:08:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2019-06-26 15:08:47 PDT

Size: 2.12 KB

patch

obsolete

>Subversion Revision: 246844
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6b0d732ad503c27f97c73862c70ead9a7f2c55a3..e4ed9595e2ec94dd5f183ff86d30235fcbcf40cb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-26  Antoine Quint  <graouts@apple.com>
>+
>+        [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
>+        https://bugs.webkit.org/show_bug.cgi?id=198999
>+        <rdar://problem/51979477>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure we don't return early prior to setting the flag that prevents re-entrancy, or else we would never
>+        enter this function again. No new tests, this was caught because Pointer Events WPT tests on iOS tests regressed.
>+
>+        * page/PointerCaptureController.cpp:
>+        (WebCore::PointerCaptureController::processPendingPointerCapture):
>+
> 2019-06-26  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
>diff --git a/Source/WebCore/page/PointerCaptureController.cpp b/Source/WebCore/page/PointerCaptureController.cpp
>index 71150f45e1938d35a5b9497d9f3c49bc02c1e891..0e023f5cfb44df759730d5250e4612544bc70370 100644
>--- a/Source/WebCore/page/PointerCaptureController.cpp
>+++ b/Source/WebCore/page/PointerCaptureController.cpp
>@@ -409,15 +409,15 @@ void PointerCaptureController::cancelPointer(PointerID pointerId, const IntPoint
> 
> void PointerCaptureController::processPendingPointerCapture(PointerID pointerId)
> {
>+    auto iterator = m_activePointerIdsToCapturingData.find(pointerId);
>+    if (iterator == m_activePointerIdsToCapturingData.end())
>+        return;
>+
>     if (m_processingPendingPointerCapture)
>         return;
> 
>     m_processingPendingPointerCapture = true;
> 
>-    auto iterator = m_activePointerIdsToCapturingData.find(pointerId);
>-    if (iterator == m_activePointerIdsToCapturingData.end())
>-        return;
>-
>     auto& capturingData = iterator->value;
> 
>     // Cache the pending target override since it could be modified during the dispatch of events in this function.

Flags:

dino: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198999: 372461 | 372463 | 372468 | 372472 | 372481 | 372551 | 372685 | 372695 | 372919 | 372923 | 372924 | 372931 | 372955