Attachment 372882 Details for Bug 198905 – Try again

[patch] Try again

bug-198905-20190616130647.patch (text/plain), 1.40 KB, created by Sam Weinig on 2019-06-25 17:15:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Weinig

Created: 2019-06-25 17:15:37 PDT

Size: 1.40 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 246481)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-06-16  Sam Weinig  <weinig@apple.com>
>+
>+        Experiment with simple structured bindings use
>+        https://bugs.webkit.org/show_bug.cgi?id=198905
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/URLHelpers.cpp:
>+        (WTF::URLHelpers::mapHostNames):
>+        Simplify code using c++ structured bindings (https://en.cppreference.com/w/cpp/language/structured_binding)
>+        to see if all the platforms will work with it.
>+
> 2019-06-12  Antoine Quint  <graouts@apple.com>
> 
>         Show the web page URL when sharing an AR model
>Index: Source/WTF/wtf/URLHelpers.cpp
>===================================================================
>--- Source/WTF/wtf/URLHelpers.cpp	(revision 246468)
>+++ Source/WTF/wtf/URLHelpers.cpp	(working copy)
>@@ -729,9 +729,7 @@ String mapHostNames(const String& string
>     // Do the mapping.
>     String result = string;
>     while (!hostNameRanges->isEmpty()) {
>-        unsigned location, length;
>-        String mappedHostName;
>-        std::tie(location, length, mappedHostName) = hostNameRanges->takeLast();
>+        auto [location, length, mappedHostName] = hostNameRanges->takeLast();
>         result = result.replace(location, length, mappedHostName);
>     }
>     return result;

Actions: View | Formatted Diff | Diff

Attachments on bug 198905: 372227 | 372882