Attachment 372873 Details for Bug 198809 – Patch

[patch] Patch

bug-198809-20190625162400.patch (text/plain), 3.70 KB, created by Timothy Hatcher on 2019-06-25 16:24:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2019-06-25 16:24:01 PDT

Size: 3.70 KB

patch

obsolete

>Subversion Revision: 246759
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7a82397ee3a094534260b9dd6a666ceeffe367c3..ea67de9a71b8d21f0ca58ce126ff956aa8ef40cd 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-06-25  Timothy Hatcher  <timothy@apple.com>
>+
>+        Clicking the up/down spin buttons for a number input increments/decrements by 2.
>+        https://bugs.webkit.org/show_bug.cgi?id=198809
>+
>+        Reviewed by Tim Horton.
>+
>+        AppKit no longer registers NSScrollerButtonDelay and NSScrollerButtonPeriod in the base
>+        NSUserDefaults for an app. This caused our use to always get 0s when setting the click
>+        and hold timer, causing the value to increment quickly for a single press.
>+
>+        * platform/mac/ScrollbarThemeMac.h:
>+        (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay): Added. Hardcode 500ms.
>+        (WebCore::ScrollbarThemeMac::autoscrollTimerDelay): Added. Hardcode 50ms.
>+        * platform/mac/ScrollbarThemeMac.mm:
>+        (WebCore::ScrollbarThemeMac::preferencesChanged): Removed use of old user defaults.
>+        (WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay): Deleted.
>+        (WebCore::ScrollbarThemeMac::autoscrollTimerDelay): Deleted.
>+
> 2019-06-24  Jer Noble  <jer.noble@apple.com>
> 
>         iOS 12.2 Drawing portrait video to canvas is sideways
>diff --git a/Source/WebCore/platform/mac/ScrollbarThemeMac.h b/Source/WebCore/platform/mac/ScrollbarThemeMac.h
>index 74aa4fd333fd68ad13b9b114d328ea76ea968b0b..cf0eeaf2a13f7cad8dd2770e76405f0bc17b5655 100644
>--- a/Source/WebCore/platform/mac/ScrollbarThemeMac.h
>+++ b/Source/WebCore/platform/mac/ScrollbarThemeMac.h
>@@ -52,8 +52,8 @@ public:
>     void usesOverlayScrollbarsChanged() override;
>     void updateScrollbarOverlayStyle(Scrollbar&)  override;
> 
>-    Seconds initialAutoscrollTimerDelay() override;
>-    Seconds autoscrollTimerDelay() override;
>+    Seconds initialAutoscrollTimerDelay() override { return 500_ms; }
>+    Seconds autoscrollTimerDelay() override { return 50_ms; }
> 
>     ScrollbarButtonsPlacement buttonsPlacement() const override;
> 
>diff --git a/Source/WebCore/platform/mac/ScrollbarThemeMac.mm b/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
>index b5d926a1b57bd4cfeb95775329b3ad543e766876..35a141a7e76b838747e7779c9a4ee7c7ef0b4cd3 100644
>--- a/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
>+++ b/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
>@@ -136,8 +136,6 @@ static const int cButtonLength[] = { 14, 10 };
> static const int cOuterButtonLength[] = { 16, 14 }; // The outer button in a double button pair is a bit bigger.
> static const int cOuterButtonOverlap = 2;
> 
>-static Seconds gInitialButtonDelay { 500_ms };
>-static Seconds gAutoscrollButtonDelay { 50_ms };
> static bool gJumpOnTrackClick = false;
> static bool gUsesOverlayScrollbars = false;
> 
>@@ -240,8 +238,6 @@ void ScrollbarThemeMac::preferencesChanged()
> {
>     NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
>     [defaults synchronize];
>-    gInitialButtonDelay = Seconds { [defaults floatForKey:@"NSScrollerButtonDelay"] };
>-    gAutoscrollButtonDelay = Seconds { [defaults floatForKey:@"NSScrollerButtonPeriod"] };
>     gJumpOnTrackClick = [defaults boolForKey:@"AppleScrollerPagingBehavior"];
>     usesOverlayScrollbarsChanged();
> }
>@@ -283,16 +279,6 @@ void ScrollbarThemeMac::updateScrollbarOverlayStyle(Scrollbar& scrollbar)
>     END_BLOCK_OBJC_EXCEPTIONS;
> }
> 
>-Seconds ScrollbarThemeMac::initialAutoscrollTimerDelay()
>-{
>-    return gInitialButtonDelay;
>-}
>-
>-Seconds ScrollbarThemeMac::autoscrollTimerDelay()
>-{
>-    return gAutoscrollButtonDelay;
>-}
>-    
> ScrollbarButtonsPlacement ScrollbarThemeMac::buttonsPlacement() const
> {
>     return gButtonPlacement;

Actions: View | Formatted Diff | Diff

Attachments on bug 198809: 372873